BUGFIX: escape quotechar
when escapechar
is not None (even if quoting=csv.QUOTE_NONE)
#61514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Found the issue on
CSVFormatter._initialize_quotechar
, wherein it only returns quotechar whenself.quoting
is notcsvlib.QUOTE_NONE
:to follow the same behavior of
csv.writer
(escape whenescapechar is not None
), I improved the if function to return quotechar whenself.escapechar is not None
in the
CSVFormatter.__init__
, moved the initialization ofself.escapechar
higher thanself.quotechar
since the initial solution was returning errors from callingself.escapechar
before its initializationinitially marked as draft to let the CIs run & check if there are tests affected by this change