An error handling for division by zero was added by throwing IllegalA… #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgumentException in the methods of Division.java.
a-ellwood
commented
Nov 1, 2024
| @@ -3,35 +3,49 @@ | |||
| public class Division { | |||
|
|
|||
| public static final long division(int a, int b) { | |||
| if (b == 0){ | |||
| throw now IllegalArgumentException ("Denominator is 0."); | |||
There was a problem hiding this comment.
Alerting user the denominator is zero.
a-ellwood
commented
Nov 1, 2024
| return result; | ||
| } | ||
|
|
||
| public static final long divisionUsingLoop(int a, int b) { | ||
| int absA = Math.abs(a); | ||
| int absB = Math.abs(b); | ||
|
|
||
| if (b == 0){ | ||
| throw now IllegalArgumentException ("Denominator is 0."); |
There was a problem hiding this comment.
Checks if denominator is 0 before the rest of the division process is complete.
a-ellwood
commented
Nov 1, 2024
| return (a > 0 && b > 0 || a < 0 && b < 0) ? result : -result; | ||
| } | ||
|
|
||
| public static final long divisionUsingRecursion(int a, int b) { | ||
| int absA = Math.abs(a); | ||
| int absB = Math.abs(b); | ||
|
|
||
| if (b == 0){ | ||
| throw now IllegalArgumentException ("Denominator is 0."); |
There was a problem hiding this comment.
Checks if denominator is 0 before the rest of the division process is complete.
a-ellwood
commented
Nov 1, 2024
| @@ -41,6 +55,10 @@ public static final long divisionUsingMultiplication(int a, int b) { | |||
| int absA = Math.abs(a); | |||
| int absB = Math.abs(b); | |||
|
|
|||
| if(b == 0){ | |||
| throw now IllegalArgumentException ("Denominator is 0."); | |||
There was a problem hiding this comment.
Checks if denominator is 0 before the rest of the division process is complete.
a-ellwood
commented
Nov 1, 2024
| @@ -59,6 +77,10 @@ public static final long divisionUsingShift(int a, int b) { | |||
| int absB = Math.abs(b); | |||
| int tempA, tempB, counter; | |||
|
|
|||
| if(b == 0){ | |||
| throw now IllegalArgumentException ("Denominator is 0."); | |||
There was a problem hiding this comment.
Checks if denominator is 0 before the rest of the division process is complete.
a-ellwood
commented
Nov 1, 2024
| @@ -78,6 +100,11 @@ public static final long divisionUsingShift(int a, int b) { | |||
| public static final long divisionUsingLogs(int a, int b) { | |||
| long absA = Math.abs(a); | |||
| long absB = Math.abs(b); | |||
|
|
|||
| if(b == 0){ | |||
| throw now IllegalArgumentException ("Denominator is 0."); | |||
There was a problem hiding this comment.
Checks if denominator is 0 before the rest of the division process is complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rgumentException in the methods of Division.java.
In this change I added if statements in each of the methods of Division to throw an IllegalArgumentException if the divisor (b) equaled 0. This allows the user to know when an error occurred with the inputted values.
By submitting this pull request I confirm I've read and complied with the below requirements.
Added {Algorithm/DS name} [{Language}], notUpdate README.mdorAdded new code.