Fix JsonWire protocol detection in test skipping

OndraM · OndraM · commit 081b70fea780 · 2019-11-29T14:00:00.000+01:00
diff --git a/tests/functional/WebDriverTestCase.php b/tests/functional/WebDriverTestCase.php
@@ -126,7 +126,7 @@ public static function skipForW3cProtocol($message = 'Not supported by W3C speci
     public static function skipForJsonWireProtocol($message = 'Not supported by JsonWire protocol')
     {
         if (getenv('GECKODRIVER') !== '1'
-            && (getenv('CHROMEDRIVER') !== '1' || getenv('DISABLE_W3C_PROTOCOL') === '1')) {
+            && (getenv('BROWSER_NAME') !== 'chrome' || getenv('DISABLE_W3C_PROTOCOL') === '1')) {
             static::markTestSkipped($message);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ public static function skipForW3cProtocol($message = 'Not supported by W3C speci`
`126`	`126`	`public static function skipForJsonWireProtocol($message = 'Not supported by JsonWire protocol')`
`127`	`127`	`{`
`128`	`128`	`if (getenv('GECKODRIVER') !== '1'`
`129`		`- && (getenv('CHROMEDRIVER') !== '1' \|\| getenv('DISABLE_W3C_PROTOCOL') === '1')) {`
	`129`	`+ && (getenv('BROWSER_NAME') !== 'chrome' \|\| getenv('DISABLE_W3C_PROTOCOL') === '1')) {`
`130`	`130`	`static::markTestSkipped($message);`
`131`	`131`	`}`
`132`	`132`	`}`