Improve codestyle and type-safety comparisons

Author: OndraM

CHANGELOG.md

@@ -13,6 +13,7 @@ This project versioning adheres to [Semantic Versioning](http://semver.org/).
 - Allow installation of Symfony 5 components.
 - Rename environment variable used to pass path to ChromeDriver executable from `webdriver.chrome.driver` to `WEBDRIVER_CHROME_DRIVER`. However the old one also still works to keep backward compatibility
 - If subdirectories in a path to screenshot destination does not exists (using `takeScreenshot()` or `takeElementScreenshot()` methods), they are automatically created.
+- When zip archive cannot be crated during file upload, throw exception instead of silently returning false.
 
 ### Fixed
 - `WebDriverExpectedCondition::presenceOfElementLocated()` works correctly when used within `WebDriverExpectedCondition::not()`.

lib/AbstractWebDriverCheckboxOrRadio.php

@@ -211,7 +211,7 @@ protected function getRelatedElements($value = null)
             $form = $this->element->findElement(WebDriverBy::xpath('ancestor::form'));
 
             $formId = $form->getAttribute('id');
-            if (!$formId) {
+            if ($formId === '' || $formId === null) {
                 return $form->findElements(WebDriverBy::xpath(
                     sprintf('.//input[@name = %s%s]', XPathEscaper::escapeQuotes($this->name), $valueSelector)
                 ));

lib/Chrome/ChromeOptions.php

@@ -142,11 +142,11 @@ public function toArray()
         // set the 'binary' to avoid returning an empty array.
         $options['binary'] = $this->binary;
 
-        if ($this->arguments) {
+        if (!empty($this->arguments)) {
             $options['args'] = $this->arguments;
         }
 
-        if ($this->extensions) {
+        if (!empty($this->extensions)) {
             $options['extensions'] = $this->extensions;
         }
 

lib/Remote/HttpCommandExecutor.php

@@ -295,7 +295,7 @@ public function execute(WebDriverCommand $command)
             }
         }
 
-        if ($params && is_array($params) && $http_method !== 'POST') {
+        if (is_array($params) && !empty($params) && $http_method !== 'POST') {
             throw new BadMethodCallException(sprintf(
                 'The http method called for %s is %s but it has to be POST' .
                 ' if you want to pass the JSON params %s',
@@ -325,7 +325,7 @@ public function execute(WebDriverCommand $command)
         $encoded_params = null;
 
         if ($http_method === 'POST') {
-            if ($params && is_array($params)) {
+            if (is_array($params) && !empty($params)) {
                 $encoded_params = json_encode($params);
             } elseif ($this->isW3cCompliant) {
                 // POST body must be valid JSON in W3C, even if empty: https://www.w3.org/TR/webdriver/#processing-model
@@ -343,7 +343,7 @@ public function execute(WebDriverCommand $command)
                 $http_method,
                 $url
             );
-            if ($params && is_array($params)) {
+            if (is_array($params) && !empty($params)) {
                 $msg .= sprintf(' with params: %s', json_encode($params));
             }
 

lib/Remote/RemoteWebDriver.php

@@ -378,7 +378,7 @@ public function takeScreenshot($save_as = null)
             $this->execute(DriverCommand::SCREENSHOT)
         );
 
-        if ($save_as) {
+        if ($save_as !== null) {
             $directoryPath = dirname($save_as);
 
             if (!file_exists($directoryPath)) {

lib/Remote/RemoteWebElement.php

@@ -446,7 +446,7 @@ public function takeElementScreenshot($save_as = null)
             )
         );
 
-        if ($save_as) {
+        if ($save_as !== null) {
             $directoryPath = dirname($save_as);
             if (!file_exists($directoryPath)) {
                 mkdir($directoryPath, 0777, true);
@@ -505,9 +505,10 @@ protected function upload($local_file)
         // Create a temporary file in the system temp directory.
         $temp_zip = tempnam(sys_get_temp_dir(), 'WebDriverZip');
         $zip = new ZipArchive();
-        if ($zip->open($temp_zip, ZipArchive::CREATE) !== true) {
-            return false;
+        if (($errorCode = $zip->open($temp_zip, ZipArchive::CREATE)) !== true) {
+            throw new WebDriverException(sprintf('Error creating zip archive: %s', $errorCode));
         }
+
         $info = pathinfo($local_file);
         $file_name = $info['basename'];
         $zip->addFile($local_file, $file_name);

lib/Remote/WebDriverCommand.php

@@ -27,7 +27,8 @@ class WebDriverCommand
     /**
      * @param string $session_id
      * @param string $name Constant from DriverCommand
-     * @param array $parameters Array of
+     * @param array $parameters
+     * @todo In 2.0 force parameters to be an array, then remove is_array() checks in HttpCommandExecutor
      */
     public function __construct($session_id, $name, $parameters)
     {