Addressing PR comments

Author: Saurabh Tripathy

Makefile

@@ -52,7 +52,7 @@ generate-code:
 	$(info Compiling deepcopy-gen...)
 	go build -o ${BIN_DIR}/deepcopy-gen ./cmd/deepcopy-gen/
 	$(info Generating deepcopy...)
-	${BIN_DIR}/deepcopy-gen  -i ./pkg/apis/controller/v1alpha1/ -O zz_generated.deepcopy 
+	${BIN_DIR}/deepcopy-gen -i ./pkg/apis/controller/v1alpha1/ -O zz_generated.deepcopy 
 
 images: verify-tag-name
 	$(info List executable directory)

doc/usage/examples/aw-1-k8s-job1.yaml

@@ -8,7 +8,7 @@ spec:
     minAvailable: 2
   resources:
     GenericItems:
-      replicas: 2
+      replicas: 1
       metadata:
         name: aw-generic-statefulset-2
         namespace: test1

doc/usage/examples/failed_logs_local.txt

@@ -5,9 +5,9 @@ apiVersion: kind.x-k8s.io/v1alpha4
 nodes:
   # the control plane node config
   - role: control-plane
-    # kubernetes version 1.21.1 from kind v0.11.0
+    # kubernetes version 1.20.7 from kind v0.11.0
     image: kindest/node:v1.20.7@sha256:e645428988191fc824529fd0bb5c94244c12401cf5f5ea3bd875eb0a787f0fe9
   # the three workers
   - role: worker
-    # kubernetes version 1.21.1 from kind v0.11.0
+    # kubernetes version 1.20.7 from kind v0.11.0
     image: kindest/node:v1.20.7@sha256:e645428988191fc824529fd0bb5c94244c12401cf5f5ea3bd875eb0a787f0fe9

doc/usage/examples/successful_log_local.txt

@@ -209,9 +209,9 @@ runTests() {
     # `go test` does not install the things it builds. `go test -i` installs
     # the build artifacts but doesn't run the tests.  The two together provide
     # a large speedup for tests that do not need to be rebuilt.
-    # go test -i "${goflags[@]:+${goflags[@]}}" \
-    #  ${KUBE_RACE} ${KUBE_TIMEOUT} "${@}" \
-    # "${testargs[@]:+${testargs[@]}}"
+    go test -i "${goflags[@]:+${goflags[@]}}" \
+    ${KUBE_RACE} ${KUBE_TIMEOUT} "${@}" \
+    "${testargs[@]:+${testargs[@]}}"
     go test "${goflags[@]:+${goflags[@]}}" \
       ${KUBE_RACE} ${KUBE_TIMEOUT} "${@}" \
      "${testargs[@]:+${testargs[@]}}" \

hack/e2e-kind-config.yaml

@@ -121,9 +121,6 @@ function cleanup {
     echo "===================================================================================="
     echo "==========================>>>>> MCAD Controller Logs <<<<<=========================="
     echo "===================================================================================="
-    echo "==========================>>>>>Printing the pod name for logs:  <<<<<=========================="
-    echo "$mcad_pod"
-    echo "_____________________________ end printing logs pod name ______________________"
     kubectl logs ${mcad_pod} -n kube-system
 
     kind delete cluster ${CLUSTER_CONTEXT}
@@ -291,13 +288,7 @@ function kube-test-env-up {
     sleep 10
     echo "Listing MCAD Controller Helm Chart and Pod YAML..."
     helm list
-    mcad-controller=$(kubectl get pods -n kube-system | grep xqueuejob | awk '{print $1}')
-    test_pod=$(kubectl get pods -n kube-system | grep xqueuejob | cut -d' ' -f1)
-    echo "_____________________________ Printing the pod name ______________________"
-    echo "$mcad_pod"
-    echo "_____________________________ end printing mcad pod name ______________________"
-    echo "$test_pod"
-    echo "_____________________________ end printing test pod name ______________________"
+    mcad-controller=$(kubectl get pods -n kube-system | grep mcad-controller | awk '{print $1}')
     if [[ "$mcad_pod" != "" ]]
     then
         kubectl get pod ${mcad_pod} -n kube-system -o yaml