Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link in Editions Overview to "required considered harmful". #206

Closed
ckdblueshark opened this issue Dec 16, 2024 · 4 comments
Closed

Comments

@ckdblueshark
Copy link

https://github.com/protocolbuffers/protocolbuffers.github.io/blame/41c8ea607ec1e444a6480a9283882d12e0fa6da3/content/editions/overview.md#L337

This should probably link to https://protobuf.dev/programming-guides/dos-donts/#add-required.

@Logofile
Copy link
Member

Thanks for raising this issue. That link shouldn't be there (it points to a topic that has internal-only guidance). I've sent an update out for review that removes the link. It should be pushed to the external site within the next couple of weeks.

@ccouzens
Copy link

As well as appearing in content/editions/overview.md it appears in content/overview.md

proto3 and strongly discouraged in proto2. For more on this, see [Required Fields Considered Harmful](/programming-guides/required-considered-harmful.md).)

@Logofile
Copy link
Member

Ah, yes. I'll remove that one, too. Thanks!

@Logofile
Copy link
Member

Updates are made. Thanks again for raising the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants