Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include invalid type name in error message #6884

Closed

Conversation

tejaschauhan36912
Copy link

  • Included invalid type name in error message for better debugging.

@sigmavirus24
Copy link
Contributor

This doesn't do what you want. What problem are you encountering? Do you have a minimal reproduction test case for it?

Copy link
Contributor

@sigmavirus24 sigmavirus24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not do what you want

@tejaschauhan36912
Copy link
Author

tejaschauhan36912 commented Feb 4, 2025

This doesn't do what you want. What problem are you encountering? Do you have a minimal reproduction test case for it?

Hi, @sigmavirus24, Thanks for replying!
I am not facing any problem with this error message in my system,
My suggestion is it's better we don't expose the max-age value in the error message, instead, we can keep the error message like , f"max-age must be integer, not {type(morsel['max-age'])}".

We can just include the invalid type it's receiving and the valid type it should have in the error message.

@sigmavirus24
Copy link
Contributor

You're not making sense and since this isn't solving a real problem, I'm closing this.

@psf psf locked and limited conversation to collaborators Feb 4, 2025
@tejaschauhan36912 tejaschauhan36912 deleted the detailed-error-message branch February 4, 2025 03:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants