Add CA constraint to test CA #6897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise recent versions of OpenSSL reject it as an invalid CA certificate (at least once the test certificates are regenerated). Fixes: psf#6896
Created using the following command with OpenSSL 3.4.0:
for cert in expired mtls valid/server; do
make -C tests/certs/$cert clean all
done
|
Let me know if you'd rather I dropped the "Regenerate test certificates" commit - but I thought it would be less confusing if the test certificates were consistent with the code that generates them. |
sigmavirus24
approved these changes
Feb 17, 2025
|
The pypy-3.9 Windows failure seems unrelated to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise recent versions of OpenSSL reject it as an invalid CA certificate.
Fixes: #6896