Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seed flaky test GARCH11::test_batched_size #7708

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nataziel
Copy link
Contributor

@nataziel nataziel commented Mar 3, 2025

seed flaky test GARCH11::test_batched_size

Description

TestGARCH11::test_batched_size is flaky in CI, seeded previously non-deterministic rng function.

Related Issue

Checklist

  • Checked that the pre-commit linting/style checks pass
  • Included tests that prove the fix is effective or that the new feature works
  • Added necessary documentation (docstrings and/or example notebooks)
  • If you are a pro: each commit corresponds to a [relevant logical change

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7708.org.readthedocs.build/en/7708/

@github-actions github-actions bot added the tests label Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.67%. Comparing base (d1aff0b) to head (7b76f67).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7708   +/-   ##
=======================================
  Coverage   92.67%   92.67%           
=======================================
  Files         107      107           
  Lines       18319    18319           
=======================================
  Hits        16977    16977           
  Misses       1342     1342           

@ricardoV94 ricardoV94 added the no releasenotes Skipped in automatic release notes generation label Mar 3, 2025
@ricardoV94
Copy link
Member

Did you confirm the things being tested are now deterministic over multiple runs, or is there something else causing stochasticity?

@nataziel
Copy link
Contributor Author

nataziel commented Mar 3, 2025

Did you confirm the things being tested are now deterministic over multiple runs, or is there something else causing stochasticity?

I did not yet as I don't have an easy way of running the tests setup on my local machine. I can't see any other places creating randomness within this functional scope, but I'll have a crack at getting the tests running in a container locally to confirm

Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no releasenotes Skipped in automatic release notes generation tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky tests/distributions/test_timeseries.py::TestGARCH11::test_batched_size
2 participants