Skip to content

feat: Normalize into immutablejs state #3506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: Normalize into immutablejs state #3506

wants to merge 1 commit into from

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Jun 12, 2025

Motivation

Solution

Open questions

Copy link

changeset-bot bot commented Jun 12, 2025

⚠️ No Changeset found

Latest commit: 008fc9c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 12, 2025

Size Change: +6 B (+0.01%)

Total Size: 77.7 kB

ℹ️ View Unchanged
Filename Size Change
examples/test-bundlesize/dist/App.js 3.42 kB 0 B
examples/test-bundlesize/dist/polyfill.js 311 B 0 B
examples/test-bundlesize/dist/rdcClient.js 10.1 kB +6 B (+0.06%)
examples/test-bundlesize/dist/rdcEndpoint.js 5.61 kB 0 B
examples/test-bundlesize/dist/react.js 57.5 kB 0 B
examples/test-bundlesize/dist/webpack-runtime.js 726 B 0 B

compressed-size-action

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 008fc9c Previous: b30806d Ratio
normalizeLong 539 ops/sec (±1.11%) 524 ops/sec (±1.32%) 0.97
denormalizeLong 272 ops/sec (±2.91%) 284 ops/sec (±2.16%) 1.04
denormalizeLong donotcache 1026 ops/sec (±0.68%) 1009 ops/sec (±0.88%) 0.98
denormalizeShort donotcache 500x 1577 ops/sec (±0.40%) 1596 ops/sec (±0.16%) 1.01
denormalizeShort 500x 816 ops/sec (±1.86%) 863 ops/sec (±1.78%) 1.06
denormalizeShort 500x withCache 5904 ops/sec (±0.49%) 6357 ops/sec (±0.76%) 1.08
queryShort 500x withCache 2659 ops/sec (±0.24%) 2762 ops/sec (±0.32%) 1.04
buildQueryKey All 53054 ops/sec (±0.59%) 55270 ops/sec (±0.39%) 1.04
query All withCache 6887 ops/sec (±0.31%) 6788 ops/sec (±0.46%) 0.99
denormalizeLong with mixin Entity 269 ops/sec (±1.82%) 281 ops/sec (±1.78%) 1.04
denormalizeLong withCache 6764 ops/sec (±0.21%) 6522 ops/sec (±0.16%) 0.96
denormalizeLong All withCache 6583 ops/sec (±0.30%) 6416 ops/sec (±0.16%) 0.97
denormalizeLong Query-sorted withCache 6898 ops/sec (±0.30%) 6861 ops/sec (±0.39%) 0.99
denormalizeLongAndShort withEntityCacheOnly 1616 ops/sec (±0.30%) 1702 ops/sec (±0.21%) 1.05
getResponse 5713 ops/sec (±1.30%) 5587 ops/sec (±1.36%) 0.98
getResponse (null) 7372141 ops/sec (±0.67%) 7377465 ops/sec (±0.61%) 1.00
getResponse (clear cache) 268 ops/sec (±2.06%) 276 ops/sec (±2.00%) 1.03
getSmallResponse 2955 ops/sec (±0.33%) 3045 ops/sec (±0.57%) 1.03
getSmallInferredResponse 2283 ops/sec (±0.12%) 2379 ops/sec (±0.43%) 1.04
getResponse Collection 5573 ops/sec (±1.10%) 5646 ops/sec (±1.30%) 1.01
get Collection 5744 ops/sec (±0.26%) 5936 ops/sec (±0.35%) 1.03
get Query-sorted 6690 ops/sec (±0.17%) 6636 ops/sec (±0.34%) 0.99
setLong 547 ops/sec (±0.47%) 526 ops/sec (±0.60%) 0.96
setLongWithMerge 248 ops/sec (±0.34%) 241 ops/sec (±0.39%) 0.97
setLongWithSimpleMerge 262 ops/sec (±0.26%) 262 ops/sec (±0.38%) 1
setSmallResponse 500x 843 ops/sec (±0.32%) 931 ops/sec (±0.46%) 1.10

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant