Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sandbox with creds includes, but from my own account #2419

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AleksandrukTad
Copy link

Hey,
I added to docs example of using graphql-request but with your own client. Unfortunately I cannot create codesandbox example from the same account as the all other examples. Could you guys help out with that?

@AleksandrukTad
Copy link
Author

##2418

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 15, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2777ccb:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration

@netlify
Copy link

netlify bot commented Jun 15, 2022

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 2777ccb
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/63ea3266d06a720008e47d84
😎 Deploy Preview https://deploy-preview-2419--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@phryneas
Copy link
Member

Going to the future, it would be best to have all the CodeSandbox examples in

https://github.com/reduxjs/redux-toolkit/tree/master/examples/query/react
they can then be linked in the docs by replacing

-https://github.com/reduxjs/redux-toolkit/tree/master/examples/query/react/graphql
+https://githubbox.com/reduxjs/redux-toolkit/tree/master/examples/query/react/graphql

You can also try this with your own branch by changing an existing example or adding a new one:
https://github.com/AleksandrukTad/redux-toolkit/tree/add-own-client-example/examples/query/react/graphql
Just change the link back to where it would be on the main repo in the final PR.

@markerikson
Copy link
Collaborator

Following up on this - @AleksandrukTad , can you redo this example by putting the code into our /examples folder (either as a standalone example, or a modification to the existing "GraphQL" example)? We can then point a sandbox to that folder.

@AleksandrukTad
Copy link
Author

Sure just been drawning in tasks lately. Will do it as soon as I got some free time :D

@AleksandrukTad
Copy link
Author

Hey, I created new examples project as graphql-custom-client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants