This repository was archived by the owner on Feb 16, 2022. It is now read-only.
Significant performance improvement by bypassing Eloquent model magic #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when attaching attribute relationships to models. When accessing Eloquent model attributes via `$model->getAttribute(...)` or `$model->attribute`, Eloquent will check if the attribute needs to be cast or mutated. This adds significant processing time when accessing attributes so instead we bypass this by calling `$model->getAttributes()['attribute']` and casting it ourselves.
|
Sorry, this probably should have been a draft pull request as there is probably some discussion to be had whether or not we can ignore considerations for changes in casts or potential mutators. |
|
@Omranic Any chance that this will be looked at? |
|
@Omranic, will be looked at? |
|
Merged, thank you! Further performance improvements, and / or test suites will be appreciated :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When accessing Eloquent model attributes via
$model->getAttribute(...)or$model->attribute, Eloquent will check if the attribute needs to be cast or mutated. This adds significant processing time when accessing attributes so instead we bypass this by calling$model->getAttributes()['attribute']and casting it ourselves.