Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixtures test: serde_yaml not implement zero copy deserializer #31

Closed
zzau13 opened this issue Apr 3, 2020 · 5 comments
Closed

Fixtures test: serde_yaml not implement zero copy deserializer #31

zzau13 opened this issue Apr 3, 2020 · 5 comments

Comments

@zzau13
Copy link
Contributor

zzau13 commented Apr 3, 2020

Can I change yaml for toml because yaml not implement zero copy deserializer, while toml does implement it?

I need it because I'm fixing the copy at Snippet to DisplayList cast
@zbraniecki
Copy link
Contributor

We use yaml only for testing, why would it matter for runtime performance to you?

@zzau13
Copy link
Contributor Author

zzau13 commented Apr 3, 2020

It's for testing, if you don't implement serde::Deserializer can not get lifetime to Snippet.

@zbraniecki
Copy link
Contributor

hmm, yeah, I don't think it'll be an issue. Feel free to switch!

@zzau13
Copy link
Contributor Author

zzau13 commented Apr 3, 2020 •
edited
Loading

It is not an issue, just a question. I didn't know any other way to talk with you 😄 , I close it

@zzau13 zzau13 closed this as completed Apr 3, 2020
@zbraniecki
Copy link
Contributor

haha, you can jump on #rust on mozilla matrix, but issues on github also work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zbraniecki @zzau13