Skip to content

Commit 669c484

Browse files
committed
Remove PhantomJS references due to SeleniumHQ dropping support
1 parent 4361e22 commit 669c484

File tree

9 files changed

+19
-43
lines changed

9 files changed

+19
-43
lines changed

.travis.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,10 @@ before_script:
1515
- "export DISPLAY=:99.0 && sh -e /etc/init.d/xvfb start"
1616
- "wget https://chromedriver.storage.googleapis.com/2.33/chromedriver_linux64.zip && unzip chromedriver_linux64.zip && sudo cp chromedriver /usr/local/bin/ && sudo chmod +x /usr/local/bin/chromedriver"
1717
- "wget https://github.com/mozilla/geckodriver/releases/download/v0.19.0/geckodriver-v0.19.0-linux64.tar.gz -O /tmp/geckodriver.tar.gz && tar -C /opt -xzf /tmp/geckodriver.tar.gz && sudo chmod 755 /opt/geckodriver && sudo ln -fs /opt/geckodriver /usr/bin/geckodriver && sudo ln -fs /opt/geckodriver /usr/local/bin/geckodriver"
18-
- "wget https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-2.1.1-linux-x86_64.tar.bz2 && tar -xvf ./phantomjs-2.1.1-linux-x86_64.tar.bz2 && export PATH=$PWD/phantomjs-2.1.1-linux-x86_64/bin:$PATH"
18+
# - "wget https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-2.1.1-linux-x86_64.tar.bz2 && tar -xvf ./phantomjs-2.1.1-linux-x86_64.tar.bz2 && export PATH=$PWD/phantomjs-2.1.1-linux-x86_64/bin:$PATH"
1919
script:
2020
- "pytest examples/my_first_test.py --browser=chrome -s"
21+
- "nosetests examples/boilerplates/boilerplate_test.py"
2122
- "pytest examples/my_first_test.py --browser=firefox -s"
22-
- "nosetests examples/my_first_test.py --browser=phantomjs"
23-
- "pytest examples/boilerplates/boilerplate_test.py"
2423
notifications:
2524
email: false

Dockerfile

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,11 @@ RUN apt-get -qy --no-install-recommends install \
7676
#===================
7777
# Install PhantomJS
7878
#===================
79-
RUN cd /usr/local/share && wget https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-2.1.1-linux-x86_64.tar.bz2
80-
RUN cd /usr/local/share && tar xjf phantomjs-2.1.1-linux-x86_64.tar.bz2
81-
RUN ln -s /usr/local/share/phantomjs-2.1.1-linux-x86_64/bin/phantomjs /usr/local/share/phantomjs
82-
RUN ln -s /usr/local/share/phantomjs-2.1.1-linux-x86_64/bin/phantomjs /usr/local/bin/phantomjs
83-
RUN ln -s /usr/local/share/phantomjs-2.1.1-linux-x86_64/bin/phantomjs /usr/bin/phantomjs
79+
# RUN cd /usr/local/share && wget https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-2.1.1-linux-x86_64.tar.bz2
80+
# RUN cd /usr/local/share && tar xjf phantomjs-2.1.1-linux-x86_64.tar.bz2
81+
# RUN ln -s /usr/local/share/phantomjs-2.1.1-linux-x86_64/bin/phantomjs /usr/local/share/phantomjs
82+
# RUN ln -s /usr/local/share/phantomjs-2.1.1-linux-x86_64/bin/phantomjs /usr/local/bin/phantomjs
83+
# RUN ln -s /usr/local/share/phantomjs-2.1.1-linux-x86_64/bin/phantomjs /usr/bin/phantomjs
8484

8585
#===========================
8686
# Configure Virtual Display
@@ -109,7 +109,6 @@ RUN cd /SeleniumBase && python setup.py develop
109109
COPY integrations/docker/docker-entrypoint.sh /
110110
COPY integrations/docker/run_docker_test_in_firefox.sh /
111111
COPY integrations/docker/run_docker_test_in_chrome.sh /
112-
COPY integrations/docker/run_docker_test_in_phantomjs.sh /
113112
RUN chmod +x *.sh
114113
COPY integrations/docker/docker_config.cfg /SeleniumBase/examples/
115114
ENTRYPOINT ["/docker-entrypoint.sh"]

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,6 @@ cd examples/
101101
pytest my_first_test.py --browser=chrome
102102

103103
nosetests my_first_test.py --browser=firefox
104-
105-
nosetests my_first_test.py --browser=phantomjs
106104
```
107105
(<i>If no browser is specified, Chrome is used by default.</i>)
108106

examples/ReadMe.md

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,6 @@ Run the example test in Firefox:
2828
pytest my_first_test.py --browser=firefox
2929
```
3030

31-
Run the example test in PhantomJS:
32-
```bash
33-
pytest my_first_test.py --browser=phantomjs
34-
```
35-
3631
Run the example test in Demo Mode (runs slower and adds highlights):
3732
```bash
3833
pytest my_first_test.py --browser=chrome --demo_mode
@@ -48,11 +43,6 @@ Run the example test suite in Firefox and generate an html report: (nosetests-on
4843
nosetests my_test_suite.py --browser=firefox --with-testing_base --report
4944
```
5045

51-
Run the example test suite in PhantomJS and generate an html report: (nosetests-only)
52-
```bash
53-
nosetests my_test_suite.py --browser=phantomjs --with-testing_base --report
54-
```
55-
5646
Run a test with configuration specifed by a config file:
5747
```bash
5848
nosetests my_first_test.py --config=example_config.cfg

help_docs/before_installation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ To run automation on various web browsers, you'll need to download a driver file
2222

2323
* For Safari, get [Safari Driver](https://github.com/seleniumbase/SeleniumBase/blob/master/help_docs/using_safari_driver.md) on your System Path.
2424

25-
* For PhantomJS headless browser automation, get [PhantomJS](http://phantomjs.org/download.html) on your System Path.
25+
* For PhantomJS headless browser automation, get [PhantomJS](http://phantomjs.org/download.html) on your System Path. (NOTE: PhantomJS is no longer officially supported by SeleniumHQ)
2626

2727
Mac:
2828

help_docs/requirements_installation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ When done, make sure the location of pip is on your path, which is `$PATH` for M
3939

4040
### [Homebrew](http://brew.sh/) (MAC-ONLY) (OPTIONAL)
4141

42-
The Homebrew package manager allows you to install things more easily on MacOS, such as Git, Chromedriver, and PhantomJS.
42+
The Homebrew package manager allows you to install things more easily on MacOS, such as Git and Chromedriver.
4343

4444
Here's the command line script to install Homebrew (*from [https://brew.sh/](https://brew.sh/)*):
4545
```bash

integrations/docker/ReadMe.md

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,23 +34,19 @@ https://docs.docker.com/engine/installation/
3434

3535
docker run seleniumbase ./run_docker_test_in_firefox.sh
3636

37-
#### 8. Now run the same test with PhantomJS inside your Docker:
38-
39-
docker run seleniumbase ./run_docker_test_in_phantomjs.sh
40-
41-
#### 9. You can also enter Docker and stay inside the shell:
37+
#### 8. You can also enter Docker and stay inside the shell:
4238

4339
docker run -i -t seleniumbase
4440

45-
#### 10. Now you can run the example test from inside the Docker shell:
41+
#### 9. Now you can run the example test from inside the Docker shell:
4642

4743
./run_docker_test_in_chrome.sh
4844

49-
#### 11. When you're satisfied, you may exit the Docker shell:
45+
#### 10. When you're satisfied, you may exit the Docker shell:
5046

5147
exit
5248

53-
#### 12. (Optional) Since Docker images and containers take up a lot of space, you may want to clean up your machine from time to time when they’re not being used:
49+
#### 11. (Optional) Since Docker images and containers take up a lot of space, you may want to clean up your machine from time to time when they’re not being used:
5450

5551
Details on that can be found here:
5652
http://stackoverflow.com/questions/17236796/how-to-remove-old-docker-containers

integrations/docker/run_docker_test_in_phantomjs.sh

Lines changed: 0 additions & 6 deletions
This file was deleted.

integrations/linux/Linuxfile.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@ sudo apt-get install -y --force-yes python-dev
6161
sudo apt-get install -y --force-yes python-MySQLdb
6262

6363
# Install PhantomJS
64-
cd ~
65-
export PHANTOM_JS="phantomjs-2.1.1-linux-x86_64"
66-
sudo wget https://bitbucket.org/ariya/phantomjs/downloads/$PHANTOM_JS.tar.bz2
67-
sudo tar xvjf $PHANTOM_JS.tar.bz2
68-
sudo mv -f $PHANTOM_JS /usr/local/share
69-
sudo ln -sf /usr/local/share/$PHANTOM_JS/bin/phantomjs /usr/local/bin
64+
# cd ~
65+
# export PHANTOM_JS="phantomjs-2.1.1-linux-x86_64"
66+
# sudo wget https://bitbucket.org/ariya/phantomjs/downloads/$PHANTOM_JS.tar.bz2
67+
# sudo tar xvjf $PHANTOM_JS.tar.bz2
68+
# sudo mv -f $PHANTOM_JS /usr/local/share
69+
# sudo ln -sf /usr/local/share/$PHANTOM_JS/bin/phantomjs /usr/local/bin
7070

7171
# Install Chrome
7272
cd /tmp

0 commit comments

Comments
 (0)