Modify logging methods

Author: startrug

helpers/web_driver_listener.py

@@ -22,48 +22,31 @@ def after_navigate_to(self, url, driver):
         self.logger.info(f"Navigated to {url}")
 
     def before_find(self, by, value, driver):
-        self.logger.info(f"Finding element by {by} {value}")
+        self.logger.info(f"Searching for element by {by} {value}")
 
     def after_find(self,by, value, driver):
         self.logger.info(f"Element by {by} {value} found")
 
     def before_click(self, element, driver):
-        self.logger.info(f"Clicking on {element.get_attribute('text')}")
+        if element.get_attribute("text") is None:
+            self.logger.info(f"Clicking on {element.get_attribute('class')}")
+        else:
+            self.logger.info(f"Clicking on {element.get_attribute('text')}")
 
     def after_click(self, element, driver):
-        self.logger.info(f"{element.get_attribute('text')} clicked")
+        if element.get_attribute("text") is None:
+            self.logger.info(f"{element.get_attribute('class')} clicked")
+        else:
+            self.logger.info(f"{element.get_attribute('text')} clicked")
 
-    # def __init__(self, driver):
-    #     self.browser = driver
-    #     self.driver = EventFiringWebDriver(self.browser, WebDriverListener())
-    #     self.logger = L.getLogger("logger")
-    #     self.navigating += self.web_driver_listener_navigating
-    #     self.navigated += self.web_driver_listener_navigated
-    #     self.finding_element += self.web_driver_listener_finding_element
-    #     self.element_clicking += self.web_driver_listener_element_clicking
-    #     self.element_clicked += self.web_driver_listener_element_clicked
-    #     self.element_value_changed += self.web_driver_listener_element_value_changed
-    #
-    # def web_driver_listener_navigating(self, sender, event_arg):
-    #     L.log(f"Navigating to {event_arg.Url}")
-    #
-    # def web_driver_listener_navigated(self, sender, event_arg):
-    #     self.log_screenshot(f"Navigated to [{event_arg.Driver.Title}]({event_arg.Url})")
-    #
-    # def web_driver_listener_finding_element(self, sender, event_arg):
-    #     self.log_message(f"Finding element `{event_arg.FindMethod}`")
-    #
-    # def web_driver_listener_element_clicking(self, sender, event_arg):
-    #     self.log_message(f"Clicking on the {event_arg.Element.TagName} `{event_arg.Element.Text}` {event_arg.Element}")
-    #
-    # def web_driver_listener_element_clicked(self, sender, event_arg):
-    #     self.log_screenshot(f"{event_arg.Element} clicked")
-    #
-    # def web_driver_listener_element_value_changed(self, sender, event_arg):
-    #     self.log_screenshot(f"Value of the {event_arg.Element} changed to `{event_arg.Value}`")
-    #
-    # def log_message(self, text):
-    #     self.logger.info(text)
-    #
-    # def log_screenshot(self, file_name):
-    #     SE.take_standard_screenshot(file_name)
+    def before_change_value_of(self, element, driver):
+        self.logger.info(f"{element.get_attribute('text')} value changed")
+
+    def before_quit(self, driver):
+        self.logger.info("Driver quitting")
+
+    def after_quit(self, driver):
+        self.logger.info("Driver quitted")
+
+    def on_exception(self, exception, driver):
+        self.logger.info(exception)

pages/login_page.py

@@ -1,57 +1,31 @@
 import allure
 from selenium.webdriver.common.keys import Keys
 from locators.locators import LogInLocators
-from selenium.webdriver.common.by import By
-from selenium.webdriver.support import expected_conditions as ec
-
 
 
 class LogInPage:
     def __init__(self, driver):
         self.driver = driver
-        #self.logger = logging.getLogger(__name__)
-
-    search_input = By.CSS_SELECTOR, "input[name='q']"
-    contact_link = "[data-target='#exampleModal']"
-    #contact_link = By.LINK_TEXT, "Contact"
 
-    @allure.step("Opening demoblaze.com website")
+    @allure.step("Opening phptravels.net website")
     def open_page(self):
-        #self.logger.info("Opening phptravels.net website")
-        self.driver.get("https://demoblaze.com/")
-
-    @allure.step("Provide text into search input")
-    def go_to_contact(self):
-        # el = ec.visibility_of(self.driver.find_element(self.contact_link))
-        e = self.driver.find_element_by_css_selector(self.contact_link)
-        e.click()
-
-    @allure.step("Provide text into search input")
-    def search(self, text):
-        self.driver.find_element(self.search_input).send_keys(text, Keys.ENTER)
+        self.driver.get("http://www.phptravels.net/")
 
     @allure.step("Expanding account menu")
     def expand_account_menu(self):
-        #self.logger.info("Expanding account menu")
         self.driver.find_element(*LogInLocators.user_account_menu).click()
 
     @allure.step("Opening login page")
     def open_login_page(self):
-        #self.logger.info("Opening login page")
         self.driver.find_element(*LogInLocators.login_link).click()
 
     @allure.step("Login with email: '1'")
     def set_user_inputs(self, email, password):
-        self.logger.info("Setting user email to {}".format(email) + " and password")
         self.driver.find_element(*LogInLocators.email_input).click()
         self.driver.find_element(*LogInLocators.email_input).send_keys(email)
         self.driver.find_element(*LogInLocators.password_input).click()
         self.driver.find_element(*LogInLocators.password_input).send_keys(password, Keys.ENTER)
 
     @allure.step("Logout")
     def logout(self):
-        self.logger.info("Logout")
         self.driver.find_element(*LogInLocators.logout_link).click()
-
-
-

pages/search_flights_form.py

@@ -1,4 +1,3 @@
-import logging
 import allure
 from allure_commons.types import AttachmentType
 from selenium.webdriver.common.by import By
@@ -10,56 +9,46 @@ class SearchFlightsForm:
 
     def __init__(self, driver):
         self.driver = driver
-        self.logger = logging.getLogger(__name__)
 
     @allure.step("Opening phptravels.net website")
     def open_page(self):
-        self.logger.info("Opening phptravels.net website")
         self.driver.get("http://www.phptravels.net/")
 
     @allure.step("Opening Flights tab")
     def open_flights_tab(self):
-        self.logger.info("Opening Flights tab")
         self.driver.find_element(*SearchTabsLocators.flights_tab).click()
 
     @allure.step("Selecting trip type to: '{1}'")
     def set_trip_type(self, trip_type):
-        self.logger.info(f"Selecting trip type to: '{trip_type}'")
         self.driver.find_element(By.XPATH, f"//label[text()='{trip_type}']").click()
 
     @allure.step("Selecting one way trip")
     def set_one_way(self):
-        self.logger.info("Selecting one way trip")
         self.driver.find_element(*SearchFlightsFormLocators.one_way_radio).click()
 
     @allure.step("Selecting round trip")
     def set_round_trip(self):
-        self.logger.info("Selecting round trip")
         self.driver.find_element(*SearchFlightsFormLocators.round_trip_radio).click()
 
     @allure.step("Setting cabin class")
     def set_cabin_class(self, cabin_class):
-        self.logger.info("Setting cabin class")
         self.driver.find_element(*SearchFlightsFormLocators.cabinclass_dropdown).click()
         self.driver.find_element(By.XPATH, f"//li[text()='{cabin_class}']").click()
 
     @allure.step("Setting location from: '{1}'")
     def set_loc_from(self, loc_from):
-        self.logger.info(f"Setting location from: {loc_from}")
         self.driver.find_element(*SearchFlightsFormLocators.loc_from_inactive).click()
         self.driver.find_element(*SearchFlightsFormLocators.loc_input_active).send_keys(loc_from)
         self.driver.find_element(By.XPATH, f"//div[@class='select2-result-label'][contains(.,'({loc_from})')]").click()
 
     @allure.step("Setting location to: '{1}'")
     def set_loc_to(self, loc_to):
-        self.logger.info(f"Setting location to: {loc_to}")
         self.driver.find_element(*SearchFlightsFormLocators.loc_to_inactive).click()
         self.driver.find_element(*SearchFlightsFormLocators.loc_input_active).send_keys(loc_to)
         self.driver.find_element(By.XPATH, f"//div[@class='select2-result-label'][contains(.,'({loc_to})')]").click()
 
     @allure.step("Setting start date to '{1}'/'{2}'/'{3}'")
     def set_start_date(self, start_year, start_month, start_day):
-        self.logger.info(f"Setting start date to {start_year}/{start_month}/{start_day}")
         self.driver.find_element(*SearchFlightsFormLocators.flight_date_start).click()
         current_year = get_datestamp(self.driver, SearchFlightsFormLocators, ["datepicker_nav_title_years"])
         if current_year != start_year:
@@ -76,7 +65,6 @@ def set_start_date(self, start_year, start_month, start_day):
 
     @allure.step("Setting end date to '{1}'/'{2}'/'{3}'")
     def set_end_date(self, end_year, end_month, end_day):
-        self.logger.info(f"Setting end date to {end_year}/{end_month}/{end_day}")
         current_year = get_datestamp(self.driver, SearchFlightsFormLocators, ["datepicker_nav_title_years"])
         if current_year != end_year:
             self.driver.find_element(*SearchFlightsFormLocators.datepicker_nav_title_end).click()
@@ -96,36 +84,30 @@ def set_end_date(self, end_year, end_month, end_day):
 
     @allure.step("Setting number of adults to '{1}'")
     def set_adults_number(self, adults_num):
-        self.logger.info(f"Setting number of adults: {adults_num}")
         set_travellers_number(self.driver, adults_num, SearchFlightsFormLocators,
                               ["adults_input_value", "adults_add", "adults_sub"])
 
     @allure.step("Setting number of adults to '{1}'")
     def set_kids_number(self, kids_num):
-        self.logger.info(f"Setting number of kids: {kids_num}")
         set_travellers_number(self.driver, kids_num, SearchFlightsFormLocators,
                               ["kids_input_value", "kids_add", "kids_sub"])
 
     @allure.step("Setting number of infants to '{1}'")
     def set_infants_number(self, infants_num):
-        self.logger.info(f"Setting number of infants: {infants_num}")
         set_travellers_number(self.driver, infants_num, SearchFlightsFormLocators,
                               ["infants_input_value", "infants_add", "infants_sub"])
 
     @allure.step("Performing search")
     def search_perform(self):
-        self.logger.info("Performing search")
         self.driver.find_element(*SearchFlightsFormLocators.search_btn).click()
         allure.attach(self.driver.get_screenshot_as_png(), name="search_results", attachment_type=AttachmentType.PNG)
 
     @allure.step("Getting input start date")
     def get_start_date(self):
         start_date = self.driver.find_element(*SearchFlightsFormLocators.flight_date_start)
         start_date_val = start_date.get_attribute("value")
-        self.logger.info("Selected start date is: ", start_date_val)
 
     @allure.step("Getting input end date")
     def get_end_date(self):
         end_date = self.driver.find_element(*SearchFlightsFormLocators.flight_date_end)
         end_date_val = end_date.get_attribute("value")
-        self.logger.info("Selected start date is: ", end_date_val)

pages/search_hotels_form.py

@@ -1,4 +1,3 @@
-import logging
 import allure
 from allure_commons.types import AttachmentType
 from locators.locators import SearchHotelsFormLocators
@@ -9,42 +8,35 @@ class SearchHotelsForm:
 
     def __init__(self, driver):
         self.driver = driver
-        self.logger = logging.getLogger(__name__)
 
     @allure.step("Opening phptravels.net website")
     def open_page(self):
-        self.logger.info("Opening phptravels.net website")
         self.driver.get("http://www.phptravels.net/")
 
     @allure.step("Setting destination to '{1}'")
     def set_destination(self, destination):
-        self.logger.info(f"Setting destination: {destination}")
         self.driver.find_element(*SearchHotelsFormLocators.destination_inactive).click()
         self.driver.find_element(*SearchHotelsFormLocators.destination_input).send_keys(destination)
         self.driver.find_element(*SearchHotelsFormLocators.search_match).click()
 
     @allure.step("Setting date range from '{1}' to '{2}'")
     def set_date_range(self, check_in, check_out):
-        self.logger.info(f"Setting date range from {check_in} to {check_out}")
         self.driver.find_element(*SearchHotelsFormLocators.checkin_input).click()
         self.driver.find_element(*SearchHotelsFormLocators.checkin_input).send_keys(check_in)
         self.driver.find_element(*SearchHotelsFormLocators.checkout_input).click()
         self.driver.find_element(*SearchHotelsFormLocators.checkout_input).send_keys(check_out)
 
     @allure.step("Setting number of adults to '{1}'")
     def set_adults_number(self, adults_num):
-        self.logger.info(f"Setting number of adults: {adults_num}")
         set_travellers_number(self.driver, adults_num, SearchHotelsFormLocators,
                               ["adults_input_value", "adults_add", "adults_sub"])
 
     @allure.step("Setting number of adults to '{1}'")
     def set_kids_number(self, kids_num):
-        self.logger.info(f"Setting number of kids: {kids_num}")
         set_travellers_number(self.driver, kids_num, SearchHotelsFormLocators,
                               ["kids_input_value", "kids_add", "kids_sub"])
 
     @allure.step("Performing search")
     def search_perform(self):
-        self.logger.info("Performing search")
         self.driver.find_element(*SearchHotelsFormLocators.search_btn).click()
         allure.attach(self.driver.get_screenshot_as_png(), name="search_results", attachment_type=AttachmentType.PNG)

pages/search_tours_form.py

@@ -1,5 +1,3 @@
-import logging
-import pytest
 import allure
 from allure_commons.types import AttachmentType
 from selenium.webdriver.common.by import By
@@ -12,35 +10,29 @@ class SearchToursForm:
 
     def __init__(self, driver):
         self.driver = driver
-        self.logger = logging.getLogger(__name__)
 
     @allure.step("Opening phptravels.net website")
     def open_page(self):
-        self.logger.info("Opening phptravels.net website")
         self.driver.get("http://www.phptravels.net/")
 
     @allure.step("Opening Tours tab")
     def open_tours_tab(self):
-        self.logger.info("Opening Tours tab")
         self.driver.find_element(*SearchTabsLocators.tours_tab).click()
 
     @allure.step("Setting tour destination: '{1}'")
     def set_tour_destination(self, tour_destination):
-        self.logger.info(f"Setting tour destination to: {tour_destination}")
         self.driver.find_element(*SearchToursFormLocators.tour_destination_inactive).click()
         self.driver.find_element(*SearchToursFormLocators.tour_destination_active).send_keys(tour_destination)
         self.driver.find_element(By.XPATH, f"//div[@class='select2-result-label']"
                                            f"[contains(.,'{tour_destination}')]").click()
 
     @allure.step("Setting tour type: '{1}'")
     def set_tour_type(self, tour_type):
-        self.logger.info(f"Setting tour type to: {tour_type}")
         self.driver.find_element(*SearchToursFormLocators.tour_type_dropdown).click()
         self.driver.find_element(*SearchToursFormLocators.tour_type_input).send_keys(tour_type, Keys.ENTER)
 
     @allure.step("Setting tour date to '{1}'/'{2}'/'{3}'")
     def set_date(self, start_year, start_month, start_day):
-        self.logger.info(f"Setting tour date to {start_year}/{start_month}/{start_day}")
         self.driver.find_element(*SearchToursFormLocators.tour_date).click()
         current_year = get_datestamp(self.driver, SearchToursFormLocators, ["datepicker_nav_title_years"])
         if current_year != start_year:
@@ -57,12 +49,10 @@ def set_date(self, start_year, start_month, start_day):
 
     @allure.step("Setting number of adults to '{1}'")
     def set_adults_number(self, adults_num):
-        self.logger.info(f"Setting number of adults: {adults_num}")
         set_travellers_number(self.driver, adults_num, SearchToursFormLocators,
                               ["adults_input_value", "adults_add", "adults_sub"])
 
     @allure.step("Performing search")
     def search_perform(self):
-        self.logger.info("Performing search")
         self.driver.find_element(*SearchToursFormLocators.search_btn).click()
         allure.attach(self.driver.get_screenshot_as_png(), name="search_results", attachment_type=AttachmentType.PNG)