Adding a test

Author: weaverryan

lib/friendly-errors/formatters/missing-loader.js

@@ -51,15 +51,8 @@ function formatErrors(errors) {
 
         messages.push('');
     }
-    return messages;
-
-    var msg = chalk.bgGreen.black('', 'WOH', '');
 
-    return [
-        msg,
-        'Hi',
-        'Hello'
-    ];
+    return messages;
 }
 
 function format(errors) {

lib/friendly-errors/transformers/missing-loader.js

@@ -24,6 +24,8 @@ function transform(error) {
         return error;
     }
 
+    error = Object.assign({}, error);
+
     const extension = getFileExtension(error.file);
     switch (extension) {
         case 'sass':
@@ -39,11 +41,12 @@ function transform(error) {
         default:
             return error;
     }
-    return Object.assign({}, error, {
-        type: TYPE,
-        severity: 900,
-        name: 'Loader not enabled'
-    });
+
+    error.type = TYPE;
+    error.severity = 900;
+    error.name = 'Loader not enabled';
+
+    return error;
 }
 
 module.exports = transform;

test/friendly-errors/transformers/missing-loader.js

@@ -0,0 +1,52 @@
+const expect = require('chai').expect;
+const transform = require('../../../lib/friendly-errors/transformers/missing-loader');
+
+describe('transform/missing-loader', () => {
+
+    describe('test transform', () => {
+        it('Error not with "ModuleParseError" name is ignored', () => {
+            const startError = {
+                name: 'OtherParseError',
+                message: 'You may need an appropriate loader',
+                file: '/path/to/file.sass'
+            };
+            const actualError = transform(Object.assign({}, startError));
+
+            expect(actualError).to.deep.equal(startError);
+        });
+
+        it('Error not containing "appropriate loader" is ignored', () => {
+            const startError = {
+                name: 'ModuleParseError',
+                message: 'Some other message',
+                file: '/path/to/file.sass'
+            };
+            const actualError = transform(Object.assign({}, startError));
+
+            expect(actualError).to.deep.equal(startError);
+        });
+
+        it('Error with unsupported file extension is ignored', () => {
+            const startError = {
+                name: 'ModuleParseError',
+                message: 'You may need an appropriate loader',
+                file: '/path/to/file.jpg'
+            };
+            const actualError = transform(Object.assign({}, startError));
+
+            expect(actualError).to.deep.equal(startError);
+        });
+
+        it('Matching error is properly transformed', () => {
+            const startError = {
+                name: 'ModuleParseError',
+                message: 'You may need an appropriate loader',
+                file: '/path/to/file.sass'
+            };
+            const actualError = transform(Object.assign({}, startError));
+
+            expect(actualError.name).to.deep.equal('Loader not enabled');
+            expect(actualError.loaderName).to.deep.equal('sass');
+        });
+    });
+});