-
Notifications
You must be signed in to change notification settings - Fork 43
FLUT-962617 - [Feature] UG content for Directional Zooming #1236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build Status: INQUEUE 🕒 |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
Build Status: INPROGRESS 🔃 |
CI Status: FAILURE ❌ |
Build Status: INQUEUE 🕒 |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine
Build Status: INQUEUE 🕒 |
Build Status: INPROGRESS 🔃 |
CI Status: FAILURE ❌ |
Build Status: INQUEUE 🕒 |
Build Status: INPROGRESS 🔃 |
CI Status: FAILURE ❌ |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
Build Status: INPROGRESS 🔃 |
CI Status: FAILURE ❌ |
Build Status: INPROGRESS 🔃 |
CI Status: FAILURE ❌ |
Build Status: INQUEUE 🕒 |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
Flutter/cartesian-charts/zoom-pan.md
Outdated
* Directional zooming functions when both [`enableDirectionalZooming`]() and [`enablePinching`](https://pub.dev/documentation/syncfusion_flutter_charts/latest/charts/ZoomPanBehavior/enablePinching.html) are set to `true`, and [`zoomMode`](https://pub.dev/documentation/syncfusion_flutter_charts/latest/charts/ZoomPanBehavior/zoomMode.html) is set to [`ZoomMode.xy`](https://pub.dev/documentation/syncfusion_flutter_charts/latest/charts/ZoomMode.html#xy). | ||
* This feature is intended for touch gestures and is ineffective with a mouse or track pad-based interactions. | ||
|
||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Image does not have quality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed gif which has quality.
Flutter/cartesian-charts/zoom-pan.md
Outdated
@@ -48,6 +48,52 @@ Pinch zooming can be enabled by [`enablePinching`](https://pub.dev/documentation | |||
{% endhighlight %} | |||
{% endtabs %} | |||
|
|||
## Directional zooming | |||
|
|||
The directional zooming feature improves the zoom experience by allowing users to zoom in and out in a specific direction (horizontal, vertical, or diagonal) depending on the angle of their pinch or drag gesture. To enable this feature, set the [`enableDirectionalZooming`]() property to `true`, the default value is `false`. The following code sample demonstrates how to enable directional zooming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not pinch or drag gestures, its only working on fingers, so can mention as finger interaction or finger gestures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with finger gestures.
Build Status: INQUEUE 🕒 |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes fine.
Feature description
Analysis and design
Followed the pinch zooming UG content and updated the directional zooming content.
Pending in adding API link for enableDirectionalZooming
Solution description
Updated content and code snippet for directional zooming in UG.
Output screenshots
Areas affected and ensured
No, areas affected.
API Changes
None.
Behavioral Changes
No behavioral changes.
Test cases
Provide the unit testing written file details to understand the use cases considered in this implementation.
If there is no TDD (if it’s not possible to follow), provide the UI automation script location and the Excel file that contains the use cases considered in this implementation.
Provide the test cases Excel file alone if the feature cannot be automated in any case.
List out all the scenarios you have tested after include these changes. You can refer the predefined scenarios from below link.
https://syncfusion.atlassian.net/wiki/display/CHARTXAMARIN/Chart+Test+Plan
Testbed sample location
Provide the test bed sample location where code reviewers can review the new feature’s behaviors. This depends on the CI process that your team follows. It can be from NPMCI, HockeyApp, staging site, local server, etc.
Does it have any known issues?
If this feature contains any known issues, provide the proper details about the issues.
Does it have memory leak?
Ensure the feature contains memory leak or not (if applicable).
MR CheckList