Skip to content

Revdep: wrong properties #6507

Open
Open
@teunbrand

Description

@teunbrand

Problem

The issue emerged from a reverse dependency check 9f80c8c and affects an estimated 8 packages.
The issue comes from us transitioning classes to S7, which is strict about the types of properties in a way ggplot2 wasn't before. The issue typically presents itself in the following shape:

ggplot2::element_text(family = TRUE, colour = 1.25)
#> Error: <ggplot2::element_text> object properties are invalid:
#> - @family must be <NULL> or <character>, not <logical>
#> - @colour cannot be a decimal number, but could be an integer.

Solution

I think allowing all types of properties is a step backward, so the right way forward is to prevent incorrect properties at the reverse dependency level.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions