-
Notifications
You must be signed in to change notification settings - Fork 4
Changes static text to reflect it belongs to DeiC Storage #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and my comments are not show-stoppers. We can merge now or leave the PR in place for further adjustments if you prefer?
aputtu
commented
Aug 11, 2025
aputtu
commented
Aug 11, 2025
aputtu
commented
Aug 11, 2025
aputtu
commented
Aug 11, 2025
aputtu
commented
Aug 11, 2025
aputtu
commented
Aug 11, 2025
Commented out quick tips services not in use, adjusted texts for active ones to leave out UCPH centric formulations. Signed-off-by: Aputsiak Niels Janussen <aputtu@gmail.com>
Altering phrases with UCPH centric fomulations. Signed-off-by: Aputsiak Niels Janussen <aputtu@gmail.com>
Signed-off-by: Aputsiak Niels Janussen <aputtu@gmail.com>
polish slightly Signed-off-by: Jonas Bardino <bardino@science.ku.dk>
polish slightly Signed-off-by: Jonas Bardino <bardino@science.ku.dk>
polish slightly Signed-off-by: Jonas Bardino <bardino@science.ku.dk>
Co-authored-by: Aputsiak Niels Janussen <aputtu@gmail.com> Signed-off-by: Jonas Bardino <bardino@science.ku.dk>
Co-authored-by: Aputsiak Niels Janussen <aputtu@gmail.com> Signed-off-by: Jonas Bardino <bardino@science.ku.dk>
Co-authored-by: Aputsiak Niels Janussen <aputtu@gmail.com> Signed-off-by: Jonas Bardino <bardino@science.ku.dk>
Co-authored-by: Aputsiak Niels Janussen <aputtu@gmail.com> Signed-off-by: Jonas Bardino <bardino@science.ku.dk>
jonasbardino
added a commit
that referenced
this pull request
Aug 11, 2025
Closing as changes here were merged through PR #314 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim has been to reflect DeiC Storage/DeiC better in the solution, so that screenshots can be made.
The static HTML snippets have been edited, so UCPH centric passages, sections, and functionality got altered or removed.
Examples are Seafile, Jupyter, and different login types for internal/external users. These are currently limited to UCPH.
Changes have sometimes been made to allow for later inclusion, simply by commenting out a HTML element.
In text passages text were removed, or altered.
There are still decisions left to be made regarding, say, external users, quotas, and so on. Once these decision have been made, it will be easier to decide which parts to completely exclude, reintroduce, and adjust.