Fix regression from PR233 to allow hyphen in sftpsubsys usernames again #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with hyphen (-) in them. Dropped the unnecessary escaping of chars and moved hyphen last in line with the standard requirement for regex patterns.
jonasbardino
added this to the
Python3 support for general research data sites milestone
rasmunk
reviewed
Jun 13, 2025
rasmunk
approved these changes
Jun 13, 2025
jonasbardino
added a commit
that referenced
this pull request
Jun 25, 2025
… with hyphen (-) in them. Dropped the unnecessary escaping of chars and moved hyphen up front in line with the standard requirement for regex patterns and discussed in original PR #262 comment. Just re-applied to `next` instead of `edge`.
|
Replaced by PR #272 . |
jonasbardino
deleted the
fix/regression-in-sftp-rejecting-usernames-containing-hyphen
branch
jonasbardino
added a commit
that referenced
this pull request
Jun 25, 2025
…in (next) (#272) Fix regression from PR233 which caused sftpsubsys to reject usernames with hyphen (-) in them. Dropped the unnecessary escaping of chars and moved hyphen up front in line with the standard requirement for regex patterns and discussed in original PR #262 comment. Just re-applied to `next` instead of `edge`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression from PR233 which caused sftpsubsys to reject usernames with hyphen (
-) in them. Dropped the unnecessary escaping of chars and moved hyphen last in line with the standard requirement for regex patterns.