Adding "AMD: Multi-step Tests" to amdproduction. #19508
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Concurrensee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request expands the CI coverage for multi-step tests by adding the amdproduction hardware mirror to the test pipeline configuration. It also includes necessary adjustments to skip specific multi-step test configurations (FLASHINFER, chunked prefill) on ROCm platforms where they are not yet supported, ensuring the test suite runs correctly on AMD hardware.
Highlights
- CI Pipeline Update: Enabled the 'Multi-step Tests (4 GPUs)' job to run on the
amdproductionhardware mirror in addition toamdexperimental. - ROCm Test Skips: Added conditional skips for multi-step tests involving FLASHINFER or chunked prefill when running on ROCm platforms, as these configurations are currently unsupported.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Concurrensee
force-pushed
the
amd_test_dix_multistep
branch
from
91e11aa to
b7600aa
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the Buildkite pipeline to include amdproduction hardware for multi-step tests and modifies a test file to correctly skip certain configurations on ROCm platforms that are not supported. The review focuses on improving the clarity and accuracy of a conditional skip in test_correctness_llm.py by simplifying a boolean comparison and refining the skip message to accurately reflect all conditions under which the test is skipped.
Concurrensee
changed the title
Concurrensee
force-pushed
the
amd_test_dix_multistep
branch
from
c97b588 to
c19ddca
Compare
Concurrensee
requested review from
tlrmchlsmth,
WoosukKwon,
mgoin and
robertgshaw2-redhat
as code owners
Concurrensee
force-pushed
the
amd_test_dix_multistep
branch
from
c19ddca to
3502165
Compare
Concurrensee
force-pushed
the
amd_test_dix_multistep
branch
from
3502165 to
68f2368
Compare
Concurrensee
force-pushed
the
amd_test_dix_multistep
branch
from
3502165 to
7b8e722
Compare
Concurrensee
force-pushed
the
amd_test_dix_multistep
branch
5 times, most recently
from
7d92e53 to
1f6ecd4
Compare
Signed-off-by: Yida Wu <yidawu@alumni.cmu.edu>
Signed-off-by: Yida Wu <yidawu@alumni.cmu.edu>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Yida Wu <yidawu@alumni.cmu.edu>
Signed-off-by: Yida Wu <yidawu@alumni.cmu.edu>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Signed-off-by: Yida Wu <yidawu@alumni.cmu.edu>
Concurrensee
force-pushed
the
amd_test_dix_multistep
branch
from
d4c3b7c to
f8a3cd4
Compare
Signed-off-by: Yida Wu <yidawu@alumni.cmu.edu> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yida Wu <yidawu@alumni.cmu.edu> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Yida Wu <yidawu@alumni.cmu.edu> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Signed-off-by: minpeter <kali2005611@gmail.com>
Signed-off-by: Yida Wu <yidawu@alumni.cmu.edu> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yida Wu <yidawu@alumni.cmu.edu> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Yida Wu <yidawu@alumni.cmu.edu> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Yida Wu <yidawu@alumni.cmu.edu> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
Signed-off-by: Yida Wu <yidawu@alumni.cmu.edu> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Adding "AMD: Multi-step Tests" to amdproduction.
Purpose: add one more test group for AMD hardware
How to test: run CI pipeline
Test result: see CI test pipeline result