Skip to content

[Frontend] early return chat format resolution when specified #19735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

xzbdmw
Copy link
Contributor

@xzbdmw xzbdmw commented Jun 17, 2025

The auto-detection of content format introduced in #9919 involves Jinja parsing, and it is time-consuming for small models and short max_tokens, such as Qwen3-0.6B with max_tokens=1. Skipping this auto-detection can provide a 3X RPS boost when using the --template-content-format string flag in L20.

@xzbdmw xzbdmw requested a review from aarnphm as a code owner June 17, 2025 08:53
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @xzbdmw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a performance bottleneck identified in the chat template content format auto-detection logic. By allowing users to explicitly specify the content format, the system can avoid unnecessary and computationally intensive Jinja parsing, leading to improved throughput and efficiency, particularly in scenarios where auto-detection overhead is significant.

Highlights

  • Performance Optimization: Introduced a mechanism to explicitly skip the time-consuming auto-detection of chat template content format, which involves Jinja parsing. This can significantly boost Requests Per Second (RPS) for specific use cases, such as small models with short max_tokens.
  • API Usage Enhancement: Users can now leverage the --template-content-format string flag to bypass the automatic detection, gaining direct control over the content format resolution process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify mergify bot added the frontend label Jun 17, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue where the auto-detection of chat template content format was not being skipped when an explicit format was provided. The changes are well-targeted and logically sound, leading to the described performance improvements.

@mergify mergify bot added the qwen Related to Qwen models label Jun 18, 2025
@aarnphm aarnphm changed the title Fixes chat-template-content-format not skipping auto detection [Frontend] early return chat format resolution when specified Jun 19, 2025
Copy link
Collaborator

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@aarnphm aarnphm added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 19, 2025
@aarnphm aarnphm enabled auto-merge (squash) June 19, 2025 11:00
@aarnphm aarnphm merged commit ea10dd9 into vllm-project:main Jun 19, 2025
79 checks passed
juncheoll pushed a commit to juncheoll/vllm that referenced this pull request Jun 23, 2025
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants