[New model support]Support Tarsier2 #19887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
princepride
requested review from
hmellor,
DarkLight1337 and
ywang96
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @princepride, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces full support for the Tarsier2 multi-modal model. The changes encompass integrating its specific processing pipeline, updating the documentation to reflect its capabilities, and providing concrete examples for its usage across various modalities (image and video). This allows users to seamlessly run Tarsier2 models within the system.
Highlights
- New Model Integration: I've added comprehensive support for the Tarsier2 multi-modal model, enabling it to process both image and video inputs. This integration leverages and extends existing Qwen2-VL processing components.
- Example Usage and Testing: New example scripts have been included for offline inference with Tarsier2, covering single-image, multi-image, and video modalities. The model has also been added to relevant test suites to ensure processing correctness and online availability.
- Documentation Update: The
supported_models.mddocumentation has been updated to reflect Tarsier2's capabilities, explicitly noting its support for Text (T), Image (I), and Video (V) modalities.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
mergify
bot
added
documentation
There was a problem hiding this comment.
Code Review
The pull request successfully adds support for the Tarsier2 model by extending the Qwen2VL implementation. Key changes involve adapting the image processor configuration, defining new model classes with appropriate inheritance and weight mapping, and updating example scripts, documentation, and test configurations. The approach of reusing existing Qwen2VL infrastructure is good for maintainability. I've identified a couple of areas where robustness could be improved, particularly in handling potentially None or malformed configuration dictionaries in Tarsier2ImageProcessor and ensuring that placeholder variables in example scripts are always initialized. These are detailed in the specific comments.
Isotr0py
reviewed
Jun 20, 2025
Isotr0py
reviewed
Jun 20, 2025
github-actions
bot
added
the
ready
|
@Isotr0py |
|
I run the command |
|
Seems just the network timeout when fetching the test video, retrying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add Tarsier2 model support: #18985 (comment)
Test Plan
python examples/offline_inference/vision_language.py -m tarsier2 --modality imagepython examples/offline_inference/vision_language.py -m tarsier2 --modality videopython examples/offline_inference/vision_language_multi_image.py -m tarsier2Test Result
Image Inference:
Video Inference:
Multi Image Inference: