Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): support unhead v2 #21106

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Conversation

userquin
Copy link
Member

@userquin userquin commented Mar 14, 2025

Description

This PR writes the Vuetify style tag using textContent instead children, children is deprecated in the current version used here (1.9.4 ).

Latest Nuxt version 3.16.0 using unhead v2 rc and the vuetify style tag without content, just the children attribute with all the css.

Check vuetifyjs/nuxt-module#298

fixes #21112

Markup:

Use the default playground and check the style is there.

image
using textContent instead children

image
vuetify style in the dom

@userquin userquin requested a review from johnleider March 14, 2025 21:45
@KaelWD KaelWD added the T: bug Functionality that does not work as intended/expected label Mar 17, 2025
@KaelWD KaelWD changed the title feat(theme): write vuetify style tag via style.textContent fix(theme): write vuetify style tag via style.textContent Mar 17, 2025
@KaelWD KaelWD added this to the v3.7.x milestone Mar 17, 2025
@KaelWD KaelWD changed the title fix(theme): write vuetify style tag via style.textContent fix(theme): support unhead v2 Mar 17, 2025
@KaelWD KaelWD merged commit 5efcacb into master Mar 17, 2025
19 checks passed
@KaelWD KaelWD deleted the userquin/feat-update-unhead-deprecations branch March 17, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.7.16] vuetify Button Hover Effect Not Working Properly in Nuxt 3
3 participants