Cache result of validation #1730
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spawnia
requested changes
Jul 11, 2025
spawnia
reviewed
Jul 14, 2025
src/Validator/ValidationCache.php
Outdated
Comment on lines
10
to
11
| * Implement this interface and pass an instance to GraphQL::executeQuery to cache validation of ASTs. The details | ||
| * of how to compute any keys (or whether to validate at all) are left up to you. |
There was a problem hiding this comment.
Suggested change
| * Implement this interface and pass an instance to GraphQL::executeQuery to cache validation of ASTs. The details | |
| * of how to compute any keys (or whether to validate at all) are left up to you. | |
| * Implement this interface and pass an instance to GraphQL::executeQuery to cache validation of ASTs. | |
| * The details of how to compute any keys (or whether to validate at all) are left up to you. |
src/Validator/ValidationCache.php
Outdated
Comment on lines
16
to
17
| * Return true if the given schema + AST pair has previously been validated successfully. | ||
| * Only successful validations are cached. A return value of false means the pair is either unknown or has not been validated yet. |
There was a problem hiding this comment.
Suggested change
| * Return true if the given schema + AST pair has previously been validated successfully. | |
| * Only successful validations are cached. A return value of false means the pair is either unknown or has not been validated yet. | |
| * Return true if the given schema + AST pair has previously been validated successfully. | |
| * Only successful validations are cached. | |
| * A return value of false means the pair is either unknown or has not been validated yet. |
| use Symfony\Component\Cache\Adapter\ArrayAdapter; | ||
| use Symfony\Component\Cache\Psr16Cache; | ||
|
|
||
| final class SpyValidationCacheAdapter extends PsrValidationCacheAdapter |
There was a problem hiding this comment.
Please put this into a separate file.
Comment on lines
35
to
36
| ++$this->markValidatedCalls; | ||
| parent::markValidated($schema, $ast); |
There was a problem hiding this comment.
Suggested change
| ++$this->markValidatedCalls; | |
| parent::markValidated($schema, $ast); | |
| ++$this->markValidatedCalls; | |
| parent::markValidated($schema, $ast); |
| $petType = new InterfaceType([ | ||
| 'name' => 'Pet', | ||
| 'fields' => [ | ||
| 'name' => ['type' => Type::string()], |
There was a problem hiding this comment.
Suggested change
| 'name' => ['type' => Type::string()], | |
| 'name' => Type::string(), |
Same in the rest of the file
Comment on lines
103
to
104
| GraphQL::executeQuery($schema, $query, null, null, null, null, null, null, $cache)->toArray(); | ||
| $result = GraphQL::executeQuery($schema, $query, null, null, null, null, null, null, $cache)->toArray(); |
There was a problem hiding this comment.
Let's assert the result is the same for both calls
| use Psr\SimpleCache\CacheInterface; | ||
| use Symfony\Component\String\Exception\InvalidArgumentException; | ||
|
|
||
| class PsrValidationCacheAdapter implements ValidationCache |
There was a problem hiding this comment.
Suggested change
| class PsrValidationCacheAdapter implements ValidationCache | |
| final class PsrValidationCacheAdapter implements ValidationCache |
There was a problem hiding this comment.
I would, but I extend this with SpyValidationCacheAdapter
tests/PsrValidationCacheAdapter.php
Outdated
| { | ||
| try { | ||
| $key = $this->buildKey($schema, $ast); | ||
| /** @phpstan-ignore-next-line */ |
There was a problem hiding this comment.
Can you use @phpstan-ignore with an error identifier here? I would like to know what is going on here.
There was a problem hiding this comment.
Oh, this has to do with stan wanting me to enumerate all the possible exceptions that could be thrown in the doc block. I argued with it for about 20 minutes but couldn't seem to satisfy it, so I gave up. If you want me to go at it again I can, but ugh. c2a82a4
spawnia
reviewed
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heyo, I remember there was some discussion about possibly disabling document validation checks a while back. I finally got around to looking into it and realized to my horror that it was indeed gobbling up a lot of resources in my app.
I don't know if you folks ever really agreed on a plan, but I thought I'd float this simple caching solution that leaves it up to the user.
Let me know what you think. If you like the general direction I can do a little polish and write better tests.