Fix swift delegate detection #8056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this? Currently we're blocked during the issue #8049 |
|
hello,could you give me a obj-c AppDelegate file.Thanks |
1 task
1 task
markdevocht
approved these changes
Jul 16, 2025
There was a problem hiding this comment.
Hi dcoulter45 👋,
Thanks for your contribution — we’ve reviewed your pull request and everything looks great!
We’ll merged it into the main branch. 🎉
Your work is now part of the project, and we really appreciate your time and effort in making this improvement.
Feel free to reach out if you have more ideas or would like to contribute again — we’d love to have you involved!
Cheers,
The ReactNativeNavigation Team
This was referenced Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During
pod installreact-native-navigation does not correctly detect if a project has an obj-c or swift AppDelegate. Resulting in the a crash sayingReactNativeNavigationModule not found#8049
This should handle both normal and monorepo projects