Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: workbenchdev/Workbench
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: workbenchdev/Workbench
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: typescript
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 23 files changed
  • 2 contributors

Commits on May 7, 2024

  1. Copy the full SHA
    773669f View commit details

Commits on May 28, 2024

  1. Compile TypeScript to JavaScript before executing (#941)

    This basically compiles from TypeScript to JavaScript at runtime when
    the "Run" button is clicked.
    
    However, there are currently 2 issues worth mentioning:
    
    ### 1. Speed
    
    Notice that this is noticeably slow because it's using `tsc`. It could
    possibly be improved by using `esbuild`, `swc`, `babel` or something
    similar but then there will be no typechecking when the "Run" button is
    clicked.
    
    However, I think the above typechecking caveat will not make much sense
    when we have real-time Intellisense in the editor for TypeScript.
    
    ### 2. Sourcemaps
    
    Another consideration is the lack of sourcemap support in GJS. While tsc
    can generate sourcemaps, this feature is disabled because GJS won't use
    them. This means that some errors will have the wrong line:column
    information.
    
    For example:
    
    
    ![image](https://github.com/workbenchdev/Workbench/assets/37999241/c6487292-18a9-4e50-85a0-5c8771f107fc)
    
    Workbench/GJS reports the error is on line number 17 even if it's
    actually on line number 22 because that's where it ends up after it's
    compiled to JavaScript (many compilers will eat up unnecessary line
    breaks even though the minify option is turned off).
    
    I left some TODOs in here where some decisions need to be made and hope
    to get some feedback
    vixalien authored May 28, 2024
    Copy the full SHA
    915fe99 View commit details

Commits on May 30, 2024

  1. Copy the full SHA
    705f025 View commit details

This comparison is taking too long to generate.

Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.

You can try running this command locally to see the comparison on your machine:
git diff main...typescript