Proposal: Make zgui a module for emscripten #22
+44
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
hazeycode
requested changes
Feb 28, 2025
| @@ -1678,7 +1678,7 @@ const ImageButton = struct { | |||
| pub fn imageButton(str_id: [:0]const u8, user_texture_id: TextureIdent, args: ImageButton) bool { | |||
| return zguiImageButton( | |||
| str_id, | |||
| user_texture_id, | |||
| @@ -1689,7 +1689,7 @@ pub fn imageButton(str_id: [:0]const u8, user_texture_id: TextureIdent, args: Im | |||
| } | |||
| extern fn zguiImageButton( | |||
| str_id: [*:0]const u8, | |||
| user_texture_id: TextureIdent, | |||
| // imgui.addCMacro("IMGUI_API", "__declspec(dllexport)"); | ||
| // imgui.addCMacro("IMPLOT_API", "__declspec(dllexport)"); | ||
| // imgui.addCMacro("ZGUI_API", "__declspec(dllexport)"); | ||
| //} |
There was a problem hiding this comment.
Note to self: Maybe this should go in the readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to build for emscripten, all library code must be imported into the wasm lib instead of linked. Zig modules seem to cover both emscripten and native builds. Also a fix in the underlying imgui lib can be removed and an additional C flag can be added to build for native wgpu.
Might be stomping on some toes by removing the shared / static library, maybe we should have a linked build and a module build side by side?
Tested against gui_test_wgpu for native and my project for native and web.