Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer OTEL to exporter if both enabled #4137

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

benjaminjb
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

We had logic to prefer OTel if both were enabled, but that was dropped so we could discuss it; this reenables that behavior with the collector util func logic.

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

If both Exporter and OTel Metrics are enabled, CPK prefers OTel.

Other Information:

If both Exporter and OTel Metrics are enabled,
CPK prefers OTel.
@benjaminjb benjaminjb merged commit 46ee186 into main Mar 19, 2025
19 checks passed
@benjaminjb benjaminjb deleted the benjb/exporter-enabled-vs-otel-metrics branch March 19, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants