Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(llmobs): fix root span tag for telemetry metrics #12828

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

Yun-Kim
Copy link
Contributor

@Yun-Kim Yun-Kim commented Mar 20, 2025

Fixes an incorrect boolean check for if a llmobs span is a root span for LLMObs telemetry metrics. This is not user facing.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@Yun-Kim Yun-Kim added the changelog/no-changelog A changelog entry is not required for this PR. label Mar 20, 2025
@Yun-Kim Yun-Kim requested a review from a team as a code owner March 20, 2025 19:45
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/llmobs/_telemetry.py                                            @DataDog/ml-observability

@Yun-Kim Yun-Kim enabled auto-merge (squash) March 20, 2025 19:50
Copy link
Contributor

github-actions bot commented Mar 20, 2025

Bootstrap import analysis

Comparison of import times between this PR and main.

Summary

The average import time in this PR is: 237 ± 2 ms.

The average import time in main is: 239 ± 2 ms.

The import time difference between this PR and main is: -1.8 ± 0.09 ms.

Import time breakdown

The following import paths have grown:

ddtrace.auto 0.019 ms (0.01%)
ddtrace.bootstrap.sitecustomize 0.019 ms (0.01%)
ddtrace.bootstrap.preload 0.019 ms (0.01%)
ddtrace.internal.products 0.019 ms (0.01%)
ddtrace.settings.dynamic_instrumentation 0.019 ms (0.01%)

The following import paths have shrunk:

ddtrace.auto 1.926 ms (0.81%)
ddtrace.bootstrap.sitecustomize 1.278 ms (0.54%)
ddtrace.bootstrap.preload 1.278 ms (0.54%)
ddtrace.internal.products 1.278 ms (0.54%)
ddtrace.internal.remoteconfig.client 0.633 ms (0.27%)
ddtrace 0.648 ms (0.27%)

@pr-commenter
Copy link

pr-commenter bot commented Mar 20, 2025

Benchmarks

Benchmark execution time: 2025-03-20 21:33:22

Comparing candidate commit bdfc241 in PR branch yunkim/llmobs-root-span-telemetry with baseline commit c314bed in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 498 metrics, 2 unstable metrics.

@Yun-Kim Yun-Kim merged commit ef35b0d into main Mar 21, 2025
395 checks passed
@Yun-Kim Yun-Kim deleted the yunkim/llmobs-root-span-telemetry branch March 21, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants