Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how to switch to JFR profiling #28269

Closed
wants to merge 1 commit into from

Conversation

r1viollet
Copy link
Contributor

What does this PR do? What is the motivation?

The documentation was missing one flag to remove the wall clock profiling that relies on the Datadog profiler.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. Your branch name MUST follow the <slack_username>/<branch_name> convention, or your pull request will not pass in CI. If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

The documentation was missing one flag to remove the wall clock profiling that relies on the Datadog profiler.
@r1viollet r1viollet requested a review from a team as a code owner March 20, 2025 14:34
@drichards-87 drichards-87 self-assigned this Mar 20, 2025
@drichards-87
Copy link
Contributor

Hi @r1viollet. Thanks for submitting the PR. Could you rename your branch so that it includes a forward slash in the branch name, e.g., r1viollet/java-jfr-profiling-trigger? The forward slash is required in order for the build job checks to successfully complete.

@drichards-87 drichards-87 added the editorial review Waiting on a more in-depth review label Mar 20, 2025
@r1viollet
Copy link
Contributor Author

Hi @r1viollet. Thanks for submitting the PR. Could you rename your branch so that it includes a forward slash in the branch name, e.g., r1viollet/java-jfr-profiling-trigger? The forward slash is required in order for the build job checks to successfully complete.

Got it, thanks.

@r1viollet r1viollet closed this Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants