Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking cleanup #239

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Breaking cleanup #239

wants to merge 3 commits into from

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Feb 11, 2025

Extracts some breaking changes from #238:

  • replace Rect{N, T}() = Rect(Vec{N, T}(Inf), Vec{N, T}(-Inf)) with Rect(Vec{N, T}(NaN), Vec{N, T}(0)) and let Integers error
  • change self_intersections() to return a vector of tuples corresponding to the intersecting lines
  • make Rect widths strictly positive (>= 0)

could also consider #181 here

Note: This is currently breaking for Makie

Base automatically changed from ff/test-coverage to master February 11, 2025 16:53
@ffreyer ffreyer force-pushed the ff/breaking-changes branch from b42bf08 to 1802ef0 Compare February 11, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant