Skip to content

Commit 55e2378

Browse files
am11danmoseleyjkotas
authored
Fix typos (dotnet#69537)
* Fix typos * Fix typo: seperate -> separate * Rename ApplicationNameSetFromArgument * Update src/coreclr/vm/methodtablebuilder.cpp * Update docs/coding-guidelines/clr-code-guide.md Co-authored-by: Dan Moseley <danmose@microsoft.com> * Update src/mono/mono/tests/verifier/make_tests.sh Co-authored-by: Dan Moseley <danmose@microsoft.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>
1 parent 534cfe3 commit 55e2378

File tree

346 files changed

+1196
-1245
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

346 files changed

+1196
-1245
lines changed

Diff for: .devcontainer/Dockerfile

+3-3
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ RUN sudo apt-get install libnss3 -y \
3434
&& apt-get install libgbm-dev -y \
3535
&& apt-get install libpango-1.0-0 -y \
3636
&& apt-get install libcairo2 -y \
37-
&& apt-get install libasound2 -y
37+
&& apt-get install libasound2 -y
3838

39-
#install firefox dependecies to run debugger tests:
39+
# install firefox dependencies to run debugger tests:
4040
RUN sudo apt-get install libdbus-glib-1-2 -y \
4141
&& apt-get install libgtk-3-0 -y \
42-
&& apt-get install libx11-xcb-dev -y
42+
&& apt-get install libx11-xcb-dev -y

Diff for: docs/coding-guidelines/clr-code-guide.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -912,7 +912,7 @@ It depends.
912912

913913
If you initialize the crst as CRST_HOST_BREAKABLE, any attempt to acquire the lock can trigger an exception (intended to kill your thread to break the deadlock.) Otherwise, you are guaranteed not to get an exception or failure. Regardless of the flag setting, releasing a lock will never fail.
914914

915-
You can only use a non host-breakable lock if you can guarantee that that lock will never participate in a deadlock. If you cannot guarantee this, you must use a host-breakable lock and handle the exception. Otherwise, a CLR host will not be able to break deadlocks cleanly.
915+
You can only use a non host-breakable lock if you can guarantee that the lock will never participate in a deadlock. If you cannot guarantee this, you must use a host-breakable lock and handle the exception. Otherwise, a CLR host will not be able to break deadlocks cleanly.
916916

917917
There are several ways we enforce this.
918918

Diff for: docs/design/coreclr/botr/readytorun-overview.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ Experiments with disabled cross-module inlining with the selectively enabled inl
265265

266266
## Non-Virtual calls as the baseline solution to all other versioning issues
267267

268-
It is important to observe that once you have a mechanism for doing non-virtual function calls in a version resilient way (by having an indirect CALL through a slot that that can be fixed lazily at runtime, all other versioning problems _can_ be solved in that way by calling back to the 'definer' module, and having the operation occur there instead. Issues associated with this technique
268+
It is important to observe that once you have a mechanism for doing non-virtual function calls in a version resilient way (by having an indirect CALL through a slot that can be fixed lazily at runtime, all other versioning problems _can_ be solved in that way by calling back to the 'definer' module, and having the operation occur there instead. Issues associated with this technique
269269

270270
1. You will pay the cost of a true indirection function call and return, as well as any argument setup cost. This cost may be visible in constructs that do not contain a call naturally, like fetching string literals or other constants. You may be able to get better performance from another technique (for example, we did so with instance field access).
271271
2. It introduces a lot of indirect calls. It is not friendly to systems that disallow on the fly code generation. A small helper stub has to be created at runtime in the most straightforward implementation, or there has to be a scheme how to pre-create or recycle the stubs.

Diff for: docs/design/coreclr/botr/xplat-minidump-generation.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Dump generation on Windows, Linux and other non-Windows platforms has several ch
44

55
Our goal is to generate core dumps that are on par with WER (Windows Error Reporting) crash dumps on any supported Linux platform. To the very least we want to enable the following:
66
- automatic generation of minimal size minidumps. The quality and quantity of the information contained in the dump should be on par with the information contained in a traditional Windows mini-dump.
7-
- simple configurabilty by the user (not _su_!).
7+
- simple configurability by the user (not _su_!).
88

99
Our solution at this time is to intercept any unhandled exception in the PAL layer of the runtime and have coreclr itself trigger and generate a "mini" core dump.
1010

Diff for: docs/design/coreclr/jit/object-stack-allocation.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ but without field edges in the connection graph.
137137
* Only simple objects are stack allocated, arrays of constant size are not analyzed.
138138
* Only objects that are allocated unconditionally in the method are moved to the stack. An improvement here would
139139
be allocating other objects dynamically on the stack.
140-
* If at least one object in a method is stack allocated, all objects are conservatively reported as as TYPE_GC_BYREF
140+
* If at least one object in a method is stack allocated, all objects are conservatively reported as TYPE_GC_BYREF
141141
and a checked write barrier is used in the method.
142142
* All objects allocated on the stack also have a pre-header allocated. Pre-header is used for synchronization
143143
and hashing so we could eliminate it if we proved the object wasn't used for synchronization and hashing.

Diff for: docs/design/coreclr/profiling/Profiler Loading.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ To enable profiling set the following environment variables:
44
- `CORECLR_PROFILER={_CLSID of profiler_}`
55

66
# Finding the profiler library
7-
Once profiling is enabled there are two ways we load your profiler, with enviroment variables (cross-plat) or through the registry (Windows only)
7+
Once profiling is enabled there are two ways we load your profiler, with environment variables (cross-plat) or through the registry (Windows only)
88

99
## Environment Variable (cross-plat)
1010
Set one of the following (if all are set, the bitness-specific variables take precedence). The 32/64 ones specify which bitness of profiler is loaded

Diff for: docs/design/coreclr/profiling/ReJIT on Attach.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ To enable ReJIT on attach there is a new API `ICorProfilerInfo10::RequestReJITWi
1414
[in, size_is(cFunctions)] mdMethodDef methodIds[]);
1515
```
1616
17-
Conceptually this works the same as `ICorProfilerInfo4::RequestReJIT` except it will automatically ReJIT any methods that have inlined the target method(s) in the past. The arguments are the same except for the additon of `dwRejitFlags` as the first parameter. The valid values for this argument come from this enum:
17+
Conceptually this works the same as `ICorProfilerInfo4::RequestReJIT` except it will automatically ReJIT any methods that have inlined the target method(s) in the past. The arguments are the same except for the addition of `dwRejitFlags` as the first parameter. The valid values for this argument come from this enum:
1818
1919
```cpp
2020
typedef enum

Diff for: docs/design/coreclr/profiling/davbr-blog-archive/Attach2.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Drawing by Magdalena Hermawan
1515

1616
There are two fundamental ways your profiler can catch up on the current state of an application:
1717

18-
- Lazy catch-up—as the profiler encounters new IDs, the profiler queries information about those IDs as it needs them, rather than assuming it has a full cache that’s always built up as the IDs are first created. This is analogous to Dorothy meeting a new grown-up, and gracefully accepting the fact that that person exists.
18+
- Lazy catch-up—as the profiler encounters new IDs, the profiler queries information about those IDs as it needs them, rather than assuming it has a full cache that’s always built up as the IDs are first created. This is analogous to Dorothy meeting a new grown-up, and gracefully accepting the fact that the person exists.
1919
- Enumeration—for certain kinds of IDs, the profiler can (at attach time) request a complete list of the currently active IDs and query information about them at that time. Sort of like Dorothy first going to the Oz City Hall and looking up the birth records for everyone.
2020

2121
Lazy catch-up is fairly self-explanatory. For example, if your sampling profiler encounters an IP in a FunctionID you’ve never seen before, just look up whatever info you need about that FunctionID the first time you encounter it, rather than assuming you’d already built up a cache when the function was first JITted. And if you discover that FunctionID resides in a module you’ve never seen before, then just look up whatever info you need about that ModuleID at that point, rather than assuming you already have a complete cache of all modules. Many of you are already doing something like this today if you support sampling against regular NGENd images (since you don’t get JIT notifications of those functions anyway).

Diff for: docs/design/features/COM-activation.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ When `DllGetClassObject()` is called in a COM activation scenario, the following
104104
}
105105
```
106106
Note this API is not exposed outside of `System.Private.CoreLib` and is subject to change at any time.
107-
* The loading of the assembly will take place in a new [`AssemblyLoadContext`](https://docs.microsoft.com/dotnet/api/system.runtime.loader.assemblyloadcontext) for dependency isolation. Each assembly path will get a seperate `AssemblyLoadContext`. This means that if an assembly provides multiple COM servers all of the servers from that assembly will reside in the same `AssemblyLoadContext`.
107+
* The loading of the assembly will take place in a new [`AssemblyLoadContext`](https://docs.microsoft.com/dotnet/api/system.runtime.loader.assemblyloadcontext) for dependency isolation. Each assembly path will get a separate `AssemblyLoadContext`. This means that if an assembly provides multiple COM servers all of the servers from that assembly will reside in the same `AssemblyLoadContext`.
108108
* The created `AssemblyLoadContext` will use an [`AssemblyDependencyResolver`](https://github.com/dotnet/runtime/issues/27787) that was supplied with the path to the assembly to load assemblies.
109109
1) The `IClassFactory` instance is returned to the caller of `DllGetClassObject()` to attempt class activation.
110110

Diff for: docs/design/features/crossgen2-compilation-structure-enhancements.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ There are 3 sets of files to pass to crossgen2:
5050
### Principles
5151

5252
1. Ahead of time generated code exists to improve startup, and for some scenarios will be retained for the lifetime of the process.
53-
2. Our default scenario relies on on tiered compilation rejit for best performance.
53+
2. Our default scenario relies on tiered compilation rejit for best performance.
5454
3. Too much pregenerated code will negatively affect applications. Startup is the critical detail for most pregeneration scenarios, and for those, there is a blend of time to pull the file to the CPU (from disk, over the network, etc.) and to compile functions. Striking the right blend has been discovered to be critical.
5555

5656
### Proposed approach

Diff for: docs/design/features/source-generator-com.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -620,7 +620,7 @@ Cons:
620620

621621
#### Option 5 (Selected Design): Only `GeneratedComInterfaceAttribute` attribute with Generated `ComWrappers`-derived type
622622

623-
The built-in `ComImport` and `ComVisible` attributes have a lot of history and weird runtime behavior associated with them. Additionally the built-in `ComVisible` attribute actually takes a `bool` to determine if the applied to type is visible and it can be applied to methods as well to enable/disable COM visbility for the legacy automatic COM vtable generation that the .NET runtime has supported since .NET Framework 1.0. This option proposes introducing a single new attribute to cover the expected scenarios:
623+
The built-in `ComImport` and `ComVisible` attributes have a lot of history and weird runtime behavior associated with them. Additionally the built-in `ComVisible` attribute actually takes a `bool` to determine if the applied to type is visible and it can be applied to methods as well to enable/disable COM visibility for the legacy automatic COM vtable generation that the .NET runtime has supported since .NET Framework 1.0. This option proposes introducing a single new attribute to cover the expected scenarios:
624624

625625
```csharp
626626
[AttributeUsage(AttributeTargets.Interface)]

Diff for: docs/design/mono/components.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ time, instead of requiring custom builds of the runtime.
2424
For example, each of the following experiences requires different runtime
2525
capabilities:
2626

27-
- Developer inner loop on on a mobile or WebAssembly workload: The runtime
27+
- Developer inner loop on a mobile or WebAssembly workload: The runtime
2828
should include support for the interpreter, hot reload, and the diagnostic
2929
server.
3030
- Release build iPhone app for the app store: The runtime should not include the

Diff for: docs/project/glossary.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ terminology.
4949
| TFM | [Target Framework Moniker](https://docs.microsoft.com/dotnet/standard/frameworks) such as `net6.0` or `netstandard2.0`. |
5050
| TPA | Trusted Platform Assemblies used to be a special set of assemblies that comprised the platform assemblies, when it was originally designed. As of today, it is simply the set of assemblies known to constitute the application. |
5151
| URT | Universal Runtime. Ancient name for what ended up being .NET, is used in the WinError facility name FACILITY_URT. |
52-
| UTC | [Universal Tuple Compiler](https://blogs.msdn.microsoft.com/vcblog/2013/06/12/optimizing-c-code-overview/). The Microsoft C++ optimizer back-end that that starts by converting the information from the FrontEnd into tuples – a binary stream of instructions. |
52+
| UTC | [Universal Tuple Compiler](https://blogs.msdn.microsoft.com/vcblog/2013/06/12/optimizing-c-code-overview/). The Microsoft C++ optimizer back-end that starts by converting the information from the FrontEnd into tuples – a binary stream of instructions. |
5353
| UWP | [Universal Windows Platform (UWP)](https://docs.microsoft.com/en-us/windows/uwp/get-started/universal-application-platform-guide) is a platform-homogeneous application architecture available on every device that runs Windows 10. |
5454
| VSD | [Virtual Stub Dispatch](../design/coreclr/botr/virtual-stub-dispatch.md). Technique of using stubs for virtual method invocations instead of the traditional virtual method table. |
5555
| VM | Virtual machine. |

Diff for: eng/native/configurecompiler.cmake

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ elseif (CLR_CMAKE_HOST_UNIX)
133133
message("Address Sanitizer (asan) enabled")
134134
endif ()
135135
if (${__UBSAN_POS} GREATER -1)
136-
# all sanitizier flags are enabled except alignment (due to heavy use of __unaligned modifier)
136+
# all sanitizer flags are enabled except alignment (due to heavy use of __unaligned modifier)
137137
list(APPEND CLR_CXX_SANITIZERS
138138
"bool"
139139
bounds

Diff for: eng/packaging.targets

+3-3
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131

3232
<PropertyGroup Condition="'$(PreReleaseVersionLabel)' == 'servicing'">
3333
<!-- If no servicing version is set we need to default to 0 in order for dependency versions to
34-
be calculated propertly, if we don't set it to 0, we would get the dependency version using the
34+
be calculated properly, if we don't set it to 0, we would get the dependency version using the
3535
product Patch Version -->
3636
<ServicingVersion Condition="'$(ServicingVersion)' == ''">0</ServicingVersion>
3737

@@ -260,13 +260,13 @@
260260
</ItemGroup>
261261
</Target>
262262

263-
<Target Name="ValidateAssemblyVersionsInRefPack"
263+
<Target Name="ValidateAssemblyVersionsInRefPack"
264264
Condition="'$(SkipValidateAssemblyVersion)' != 'true' and '$(_AssemblyInTargetingPack)' == 'true' and '$(PreReleaseVersionLabel)' == 'servicing'"
265265
AfterTargets="CoreCompile" >
266266
<Error Condition="'$(AssemblyVersion)' != '$(LastReleasedStableAssemblyVersion)'" Text="AssemblyVersion should match last released assembly version $(LastReleasedStableAssemblyVersion)" />
267267
</Target>
268268

269-
<Target Name="ValidateServicingVersionIsPropertlySet"
269+
<Target Name="ValidateServicingVersionIsProperlySet"
270270
Condition="'$(PreReleaseVersionLabel)' == 'servicing' and '$(DotNetBuildFromSource)' != 'true'"
271271
AfterTargets="GenerateNuspec">
272272
<Error Condition="'$(ServicingVersion)' == '0'" Text="ServicingVersion is set to 0 and it should be an increment of the patch version from the last released package." />

Diff for: eng/pipelines/mono/templates/xplat-pipeline-job.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ jobs:
5858
- name: buildProductArtifactName
5959
value: 'MonoProduct__${{ parameters.runtimeVariant }}_$(osGroup)$(osSubgroup)_$(archType)_$(buildConfig)'
6060

61-
# minijit and monointerpreter do not use seperate product builds.
61+
# minijit and monointerpreter do not use separate product builds.
6262
- ${{ if or(eq(parameters.runtimeVariant, 'minijit'), eq(parameters.runtimeVariant, 'monointerpreter')) }}:
6363
- name : buildProductArtifactName
6464
value : 'MonoProduct___$(osGroup)$(osSubgroup)_$(archType)_$(buildConfig)'
@@ -107,7 +107,7 @@ jobs:
107107
value: 'Checked'
108108
${{ if eq(parameters.liveRuntimeBuildConfig, 'debug') }}:
109109
value: 'Debug'
110-
110+
111111
- name: priorityArg
112112
value: ''
113113

Diff for: src/coreclr/System.Private.CoreLib/src/System/Reflection/LoaderAllocator.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ namespace System.Reflection
1010
// We can destroy the unmanaged part of collectible type only after the managed part is definitely gone and thus
1111
// nobody can call/allocate/reference anything related to the collectible assembly anymore. A call to finalizer
1212
// alone does not guarantee that the managed part is gone. A malicious code can keep a reference to some object
13-
// in a way that that survives finalization, or we can be running during shutdown where everything is finalized.
13+
// in a way that it survives finalization, or we can be running during shutdown where everything is finalized.
1414
//
1515
// The unmanaged LoaderAllocator keeps a reference to the managed LoaderAllocator in long weak handle. If the long
1616
// weak handle is null, we can be sure that the managed part of the LoaderAllocator is definitely gone and that it

Diff for: src/coreclr/classlibnative/bcltype/objectnative.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ NOINLINE static Object* GetClassHelper(OBJECTREF objRef)
193193
return OBJECTREFToObject(refType);
194194
}
195195

196-
// This routine is called by the Object.GetType() routine. It is a major way to get the Sytem.Type
196+
// This routine is called by the Object.GetType() routine. It is a major way to get the System.Type
197197
FCIMPL1(Object*, ObjectNative::GetClass, Object* pThis)
198198
{
199199
CONTRACTL

Diff for: src/coreclr/classlibnative/bcltype/varargsnative.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ static void InitCommon(VARARGS *data, VASigCookie** cookie)
9191
// += sizeOfArgs
9292
// /
9393
// <arg1> /
94-
// * <this> ;; if an instance method (note: <this> is usally passed in
94+
// * <this> ;; if an instance method (note: <this> is usually passed in
9595
// ;; a register and wouldn't appear on the stack frame)
9696
// ;; higher memory
9797
//

Diff for: src/coreclr/debug/createdump/crashreportwriter.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ CrashReportWriter::Indent(std::string& text)
309309
}
310310

311311
void
312-
CrashReportWriter::WriteSeperator(std::string& text)
312+
CrashReportWriter::WriteSeparator(std::string& text)
313313
{
314314
if (m_comma)
315315
{
@@ -323,7 +323,7 @@ void
323323
CrashReportWriter::OpenValue(const char* key, char marker)
324324
{
325325
std::string text;
326-
WriteSeperator(text);
326+
WriteSeparator(text);
327327
if (key != nullptr)
328328
{
329329
text.append("\"");
@@ -354,7 +354,7 @@ void
354354
CrashReportWriter::WriteValue(const char* key, const char* value)
355355
{
356356
std::string text;
357-
WriteSeperator(text);
357+
WriteSeparator(text);
358358
text.append("\"");
359359
text.append(key);
360360
text.append("\" : \"");

Diff for: src/coreclr/debug/createdump/crashreportwriter.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class CrashReportWriter
3131
void Write(const std::string& text);
3232
void Write(const char* buffer);
3333
void Indent(std::string& text);
34-
void WriteSeperator(std::string& text);
34+
void WriteSeparator(std::string& text);
3535
void OpenValue(const char* key, char marker);
3636
void CloseValue(char marker);
3737
bool OpenWriter(const char* fileName);

0 commit comments

Comments
 (0)