Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nr2: Add missing function to silence error #3517

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Nr2: Add missing function to silence error #3517

merged 1 commit into from
Mar 24, 2025

Conversation

P-E-P
Copy link
Member

@P-E-P P-E-P commented Mar 20, 2025

No description provided.

@P-E-P P-E-P force-pushed the nr2-missing-function branch from 41ee9dc to c6b1792 Compare March 20, 2025 16:44
@P-E-P P-E-P marked this pull request as ready for review March 20, 2025 16:45
@P-E-P P-E-P requested a review from philberty March 20, 2025 16:45
@powerboat9
Copy link
Collaborator

Although it doesn't really matter, as this test is never supposed to get to type checking, the printf string should probably be cast to a * const i8 (by first casting to a *const str) and end with an \0

@P-E-P
Copy link
Member Author

P-E-P commented Mar 20, 2025

Although it doesn't really matter, as this test is never supposed to get to type checking, the printf string should probably be cast to a * const i8 (by first casting to a *const str) and end with an \0

Yeah you're right.

@P-E-P P-E-P force-pushed the nr2-missing-function branch 2 times, most recently from 13ebe99 to ae209f3 Compare March 20, 2025 17:05
@powerboat9
Copy link
Collaborator

Also, the two commits should probably be squashed together, so that the testsuite passes on every commit added to master

CohenArthur
CohenArthur approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @powerboat9 regarding the commits, but other than that this looks good to me!

@P-E-P P-E-P force-pushed the nr2-missing-function branch from ae209f3 to d7e0700 Compare March 24, 2025 10:33
@P-E-P
Fix function name to printf
ccfc128 
Function could not be found and triggered an error message.

gcc/testsuite/ChangeLog:

	* rust/compile/feature_rust_attri0.rs: Add extern
	function declaration and change name to printf.
	* rust/compile/nr2/exclude: Remove now passing test from exclusion
	list.

Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
@P-E-P P-E-P force-pushed the nr2-missing-function branch from d7e0700 to ccfc128 Compare March 24, 2025 10:35
@P-E-P P-E-P added this pull request to the merge queue Mar 24, 2025
Merged via the queue into Rust-GCC:master with commit bb08a82 Mar 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CohenArthur CohenArthur

@philberty philberty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P-E-P @powerboat9 @CohenArthur