Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document DAEProblem constructor #3495

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vyudu
Copy link
Member

@vyudu vyudu commented Mar 25, 2025

Fix #3485

@cstjean
Copy link
Contributor

cstjean commented Mar 27, 2025

If possible, it is recommended to formulate your problem in terms of an ODEProblem

In MTK, this boils down to "avoid algebraic constraints other than a = b equalities and sum-of-flow equations", right?

@vyudu
Copy link
Member Author

vyudu commented Mar 27, 2025

sorry, my message is kind of misleading, ODEProblem can be used for systems with arbitrary algebraic equations attached to them, what I mean here is to formulate DAEs in terms of the mass matrix Mu' = f(u, p, t) (for the ODEProblem) rather than the fully implicit form f(u', u, p, t) = 0 (for the DAEProblem) if possible/convenient.

To be honest, I'm not sure if there's any cases where you actually should or need to make a DAEProblem from a MTK system since it seems like ODESystems are naturally in the mass matrix form, so maybe this message should be more explicit along the lines of "You shouldn't ever use DAEProblem". But I'm not sure if this is true. @ChrisRackauckas ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document DAEProblem constructor and give a warning about performance implications
2 participants