-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: compute jac_prototype for SDEFunction #3535
Conversation
Can we make sure to add the mass matrix into the pattern? Because it will be a requirement of the future, so we should just make it robust now. |
Mass matrix is already in there |
The mass matrix is a subset of |
No I mean it was there before, see lines 656-657 of the updated file |
@ChrisRackauckas @oscardssmith @AayushSabharwal
is this right? anything I'm missing? |
Nevermind this is writing to the wrong entries, need to investigate |
So this is good to go? |
No I think it's still writing to the wrong entries sorry, investigating |
OK I think I fixed it, let's see how tests do. |
Close #3527