Skip to content

ref(core): switch from Object.defineProperty to Proxies #9079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2025
Merged

ref(core): switch from Object.defineProperty to Proxies #9079

merged 2 commits into from
Apr 29, 2025

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Apr 29, 2025 •
edited
Loading

All environments we support have Proxies, so we can now switch to using them for perf.

@github-actions github-actions bot added documentation Improvements or additions to documentation package: query-core labels Apr 29, 2025
@TkDodo TkDodo mentioned this pull request Apr 29, 2025
Closed
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 29, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit c8f59bf.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 33s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 34s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-29 09:56:58 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 29, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9079

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9079

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9079

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9079

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9079

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9079

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9079

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9079

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9079

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9079

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9079

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9079

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9079

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9079

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9079

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9079

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9079

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9079

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9079

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9079

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9079

commit: c8f59bf

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2025 •
edited
Loading

Sizes for commit c8f59bf:

Branch Bundle Size
Main
This PR

@codecov Codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 59.01%. Comparing base (8c7df63) to head (c8f59bf).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9079       +/-   ##
===========================================
+ Coverage   44.58%   59.01%   +14.42%     
===========================================
  Files         203      138       -65     
  Lines        8104     5355     -2749     
  Branches     1808     1419      -389     
===========================================
- Hits         3613     3160      -453     
+ Misses       4059     1906     -2153     
+ Partials      432      289      -143
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.23% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 95.94% <20.00%> (-0.01%) ⬇️
@tanstack/query-devtools 3.61% <ø> (ø)
@tanstack/query-persist-client-core 73.46% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.48% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.15% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.10% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TkDodo TkDodo merged commit 10493ef into main Apr 29, 2025
6 of 7 checks passed
@TkDodo TkDodo deleted the feature/proxies branch April 29, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation package: query-core package: react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TkDodo