fix: Hard break keyboard shortcut not working in custom blocks #1554
+72
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
reviewed
Mar 21, 2025
nperez0111
reviewed
Mar 24, 2025
| @@ -179,7 +179,7 @@ const getTipTapExtensions = < | |||
| types: ["blockContainer", "columnList", "column"], | |||
| setIdAttribute: opts.setIdAttribute, | |||
| }), | |||
| HardBreak.extend({ priority: 10 }), | |||
There was a problem hiding this comment.
Priority makes sense, since it needs to be higher priority
nperez0111
reviewed
Mar 24, 2025
packages/core/src/extensions/KeyboardShortcuts/KeyboardShortcutsExtension.ts
Outdated
Show resolved
Hide resolved
nperez0111
reviewed
Mar 24, 2025
|
@nperez0111 @matthewlipski let's maybe also think through whether this should be configurable or not.
|
|
True, yea let's discuss what we want here, I've seen a lot of stuff lately around custom blocks & newline behaviour: |
|
I added a proposal for configuring the hard break shortcut behaviour in the most recent commit. Lmk if it seems ok! |
YousefED
reviewed
Mar 27, 2025
packages/core/src/extensions/KeyboardShortcuts/KeyboardShortcutsExtension.ts
Outdated
Show resolved
Hide resolved
|
@matthewlipski can you add docs for this + comment the BlockConfig in the code? (let's make this standard practice) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1554