Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Multi-block links #1565

Merged
merged 2 commits into from
Mar 27, 2025
Merged

fix: Multi-block links #1565

merged 2 commits into from
Mar 27, 2025

Conversation

matthewlipski
Copy link
Collaborator

@matthewlipski matthewlipski commented Mar 26, 2025

Currently, creating a new link which spans multiple blocks merges them together. This PR fixes that, and also makes the formatting toolbar button for creating links only show the URL field (previously URL + text), as this is more in line with Notion/GDocs UX.

Closes #1527

Copy link

vercel bot commented Mar 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Mar 26, 2025 4:31pm
blocknote-website ✅ Ready (Inspect) Visit Preview Mar 26, 2025 4:31pm

Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I guess someone can re-enable the text input if they want?

@matthewlipski
Copy link
Collaborator Author

Yeah they can, though I doubt this is going to be smth many people do anyway

@matthewlipski matthewlipski merged commit 5558a51 into main Mar 27, 2025
7 checks passed
@matthewlipski matthewlipski deleted the multi-block-links-fix branch March 27, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link on several blocks cause merge
2 participants