chore: Reduce production bundle sizes #7977
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces production bundle sizes for our libraries by making some parts of the code gated behind
process.env.NODE_ENVchecks. This is now possible as of Parcel v2.14.0: parcel-bundler/parcel#10102 In particular, console warnings and errors now only appear in development, and will be compiled away in production apps to avoid including those strings.Also, some fallback code in usePress, useHover, useMove, etc. for environments that don't support pointer events is now only included when
NODE_ENV === 'test'. These branches are not used in any real browser because all browsers have supported pointer events for a while now, but JSDOM still does not support them, so we need to keep this code to avoid breaking everyone's tests. However, omitting them in browser builds should be safe and cuts the bundle size of these hooks in half.