Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HA: set correct hostId of HA work for vm migration #10591

Draft
wants to merge 2 commits into
base: 4.19
Choose a base branch
from

Conversation

weizhouapache
Copy link
Member

Description

This PR fixes 3 issues

  • set correct hostId of HA work for vm migration
  • skip migration job if vm is running on a different host
  • wait 10 seconds for all modules are loaded

The issues are found when

  • put host to maintenance
  • restart management server

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

this fixes
```
2025-03-04T07:58:13,306 WARN  [c.c.h.HighAvailabilityManagerExtImpl] (HA-Worker-2:[ctx-3dc0c480, work-256]) (logid:431cd943) Encountered unhandled exception during HA process, reschedule work java.lang.NullPointerException: Cannot invoke "org.apache.cloudstack.framework.jobs.AsyncJob.getId()" because "job" is null
```
@weizhouapache weizhouapache changed the title 4.19 fix ha work hostid HA: set correct hostId of HA work for vm migration Mar 20, 2025
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.28%. Comparing base (6c40a7b) to head (c6a682c).

❗ There is a different number of reports uploaded between BASE (6c40a7b) and HEAD (c6a682c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6c40a7b) HEAD (c6a682c)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               4.19   #10591       +/-   ##
=============================================
- Coverage     15.16%    4.28%   -10.88%     
=============================================
  Files          5414      368     -5046     
  Lines        474811    29656   -445155     
  Branches      57911     5207    -52704     
=============================================
- Hits          72017     1272    -70745     
+ Misses       394742    28239   -366503     
+ Partials       8052      145     -7907     
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12842

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12845

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12788)

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12847

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12792)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 49672 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10591-t12792-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@Pearl1594 Pearl1594 added this to the 4.19.3 milestone Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants