Remove macros from some trait implementation #265
Conversation
There was a problem hiding this comment.
Can you please rebase it without the merge commit. Your HEAD for checkout of new branch to add changes should be upstream(arrayfire/arrayfire) master branch - the same branch against which the PR is made.
I was playing with trait bound on associated types locally, haven't pushed to my fork yet. Seems like the CI job ran fine with such bounds.
Also, please squash the commits that are adding HasAfEnum trait bound to associated type into a single commit as they all are essentially doing same type of change - Adding HasAfEnum trait bound to associated types
|
Sorry, I'm not used to sending PR. I did rebase, squash and made another branch: What should I do now? Sending another PR, or can I overwrite current PR? |
- Simplify `Convertable` trait definition - Force `ImplicitPromote::Output` to be `HasAfEnum`. This is aimed at improving usability for generic code. - Simplify `ConstGenerator` trait definition
9prady9
force-pushed
the
improve-trait-definition
branch
from
262afad to
ff6a0f2
Compare
I took care of it. No need to create another PR. I want to make changes only if needed to yours after some local testing. Hope that is okay by you. |
9prady9
force-pushed
the
improve-trait-definition
branch
from
ff6a0f2 to
ddbc2d3
Compare
Avoiding macro provides better usability for library users.
9prady9
force-pushed
the
improve-trait-definition
branch
from
ddbc2d3 to
545f16d
Compare
|
Thanks for your kind help! |
|
I believe more improvements are needed to further improve generic function programming. I am working on it right now. Hopefully, the bounds specification will simplify down further. This PR is good by itself. @atomicky Thank you for the contribution. |
This clarify relationship of traits (see #264 ).