Fixed an issue in S3 client where a GetObject request m… #5977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
changed the title
zoewangg
force-pushed
the
zoewang/s3crtclient-fix
branch
from
09c6ef5 to
4f0e173
Compare
zoewangg
force-pushed
the
zoewang/s3crtclient-fix
branch
from
4f0e173 to
023f74c
Compare
…ay hang if streaming failed mid request
zoewangg
force-pushed
the
zoewang/s3crtclient-fix
branch
from
023f74c to
ae30c8c
Compare
L-Applin
reviewed
Mar 27, 2025
There was a problem hiding this comment.
For my understanding, why are we changing this?
There was a problem hiding this comment.
This file was automatically updated after I ran mvn package. It basically means the suppressions are no longer needed. It could be that we fixed the violations or simply removed the code that had the violations
zoewangg
commented
Mar 27, 2025
| @@ -48,7 +48,8 @@ public class CodingConventionWithSuppressionTest { | |||
| private static final Set<Pattern> ALLOWED_WARN_LOG_SUPPRESSION = new HashSet<>( | |||
| Arrays.asList(ArchUtils.classNameToPattern(EmfMetricLoggingPublisher.class), | |||
| ArchUtils.classNameToPattern(MetricEmfConverter.class), | |||
| ArchUtils.classNameToPattern(MakeHttpRequestStage.class))); | |||
| ArchUtils.classNameToPattern(MakeHttpRequestStage.class), | |||
| ArchUtils.classNameToPattern("software.amazon.awssdk.services.s3.internal.crt.S3CrtResponseHandlerAdapter"))); | |||
There was a problem hiding this comment.
Passing S3CrtResponseHandlerAdapter.class does not work because it'd try to load CRT classes and fail and we don't want to include CRT dependency in our arch tests
|
L-Applin
approved these changes
Mar 27, 2025
Fred1155
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ay hang if streaming failed mid request
Motivation and Context
May be related to #5755
Modifications
Fixed an issue in AWS CRT-based S3 client where a GetObject request may hang if streaming failed mid request.
In the AWS CRT-based S3 client, if there is an I/O error thrown, we notify the response handler through
responseHandler#onError. WhenAsyncResponseTransformer#toBlockingInputStreamis used, it just completed the future exceptionally and doesn't send error to the underlying subscriberhttps://github.com/aws/aws-sdk-java-v2/blob/master/core/sdk-core/src/main/java/software/amazon/awssdk/core/internal/async/InputStreamResponseTransformer.java#L60
Testing
Added unit tests and verified through smoke tests (turning off wifi mid streaming to simulate the error)
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License