Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: logging.getLogger('root') does not get you the root logger #56

Closed
howardjones opened this issue Aug 25, 2020 · 2 comments
Closed

docs: logging.getLogger('root') does not get you the root logger #56

howardjones opened this issue Aug 25, 2020 · 2 comments

Comments

@howardjones
Copy link

howardjones commented Aug 25, 2020 •
edited
Loading

In the README, it says to use logging.getLogger('root') to initialise the root logger. That doesn't do that. That initialises a logger called "root".logging.getLogger(None) gets you the root logger.

(Just spent a while with logging_tree to figure out why I couldn't getting JSON logging working in non-main modules)
@bobbui
Copy link
Owner

bobbui commented Aug 26, 2020

will take a lôk

bobbui pushed a commit to nickma82/json-logging-python that referenced this issue Aug 28, 2020
Fix bobbui#57 and bobbui#56
569b745
@bobbui
Copy link
Owner

bobbui commented Aug 28, 2020

updated docs thanks!

@bobbui bobbui closed this as completed Aug 28, 2020
bobbui pushed a commit that referenced this issue Aug 28, 2020
Fix #57 and #56
40855ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@howardjones @bobbui