|
2 | 2 | 1. Make sure you have read and understand the **Goals** section to be aligned with project goals.
|
3 | 3 | 2. Before submitting a PR please comment in the relevant issue (or create a new one if it doesn't exist yet) to discuss all the requirements (this will prevent rejecting the PR and wasting your work).
|
4 | 4 | 3. All workflow scripts (prettier, linter, tests) must pass successfully.
|
5 |
| -4. Don't edit `README.md` directly - it is built using `sh ./generate.sh` script to inject code snippets from the sources in the `/playground` folder (this will make sure all code examples are nicely formatted and working) |
6 |
| - - To make changes in `README.md` edit `.md` files that are located in the `/docs/markdown` folder |
7 |
| - - To make changes in code snippets edit source files in `/playground` folder |
8 |
| - - include directives look like this: `::[example|usage]='../../playground/src/components/sfc-counter.tsx'::` |
9 |
| -5. When submitting a PR please make sure that you run the following: |
10 |
| -```bash |
11 |
| -# run linter in `/playground` folder |
12 |
| -npm run lint |
| 5 | +4. Don't edit `README.md` directly - it is built using generator from `README_SOURCE.md`. |
| 6 | + - Use `sh ./generate-readme.sh` script to generate `README.md` (this will inject code examples using type-checked source files from the `/playground` folder) |
| 7 | + - include directives look like this: `::[example|usage]='playground/src/components/sfc-counter.tsx'::` |
| 8 | + - To make changes in code examples edit source files in `/playground` folder |
13 | 9 |
|
14 |
| -# run type-checking in `/playground` folder |
15 |
| -npm run tsc |
| 10 | +**Mandatory PR checklist**: |
| 11 | +- generate a new `README.md` from `README_SOURCE.md` using command: |
| 12 | +``` |
| 13 | +sh ./generate-readme.sh |
16 | 14 |
|
17 |
| -# always re-generate `README.md` from root folder |
18 |
| -sh ./generate.sh |
19 |
| -# don't like bash scripts? simply use node.js script |
20 |
| -# node ./generator/bin/generate-readme.js |
| 15 | +# or if you don't like bash, simply use node.js |
| 16 | +# node ./generate-readme.js |
21 | 17 | ```
|
0 commit comments