Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README and improve getting started experience #2

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

twalthr
Copy link
Member

@twalthr twalthr commented Sep 5, 2024

No description provided.

@twalthr twalthr requested a review from a team as a code owner September 5, 2024 05:36
@snuyanzin
Copy link

Great write up, was enjoyed going through it
I put. a couple of minor comments

@snuyanzin
Copy link

a side note: looks like it is not compatible with jdk21
since Flink 1.20 supports jdk21 would it make sense to add support here as well?

@pull-request-watcher

This comment has been minimized.

@pull-request-watcher
Copy link

Guidelines and Expectations for Peer Reviews

Please review the wiki and ensure you understand the behavior of the GitHub branch protection policies, and what is expected of pull request authors and reviewers.

Copy link

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked that the project is able to be built with jdk 11, 17, 21

@twalthr twalthr merged commit fca74d8 into master Sep 5, 2024
@twalthr twalthr deleted the SQL-2349 branch September 5, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants