-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable test_all, fix _aliases.__all__
#286
Open
ev-br
wants to merge
6
commits into
data-apis:main
Choose a base branch
from
ev-br:test_all
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5473d84.
0e339fc
to
9bb1021
Compare
ev-br
commented
Mar 23, 2025
Merged
I think I might want to merge this PR sooner than later, if only to restore the state of the tests and make the CI green by default. Please speak up if you want some more time to review. |
lucascolley
approved these changes
Mar 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Evgeni! Just one comment
ev-br
commented
Mar 29, 2025
Co-authored-by: Evgeni Burovski <evgeny.burovskiy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes gh-283
test_all
common._aliases.__all__
which was wrongSo the
__all__
list was wrong for a while, but it was not caught be tests because:$ pytest tests/
locallysys.modules
. So if an implementation module is not imported, it's not checked: this was the case withcommon._aliases
until BUG: torch: fixresult_type
with python scalars #277 added an unrelated test.