-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docker-outside-of-docker] - Correction in fetching previous version from github api url #1252
[docker-outside-of-docker] - Correction in fetching previous version from github api url #1252
Conversation
…from github api url
…ning to latest release
…ray, so to tackle both the scenarios in the function of fallbacking
This same concern happened again today with a new release. Any chance this could be reviewed and merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the minor version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If user passes the version as v2 this condition will not satisfy for latest tag and fallback mechanism will fail: Removing this condition resolves the issue
Feature Name
Docker-Outside-Of-Docker
Description of Changes
Docker-outside-of-Docker
Feature as previously it was fetching thelatest
version in a plight to fetch theprevious
version from theGitHub API URL
, which was misleading and therefore now fetching the second element'stag_name
property's value inreleases
array json for correcting the aboveChangelog
install.sh
filedocker_build_compose_fallback.sh
file in test case scenarios implementations of docker-outside-of-dockerChecklist