Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker-outside-of-docker] - Correction in fetching previous version from github api url #1252

Merged

Conversation

gauravsaini04
Copy link
Contributor

@gauravsaini04 gauravsaini04 commented Jan 27, 2025

Feature Name

  • Docker-Outside-Of-Docker

Description of Changes

  • Correcting the fallback method for Docker-outside-of-Docker Feature as previously it was fetching the latest version in a plight to fetch the previous version from the GitHub API URL, which was misleading and therefore now fetching the second element's tag_name property's value in releases array json for correcting the above

Changelog

  • Made changes to install.sh file
  • Made changes to docker_build_compose_fallback.sh file in test case scenarios implementations of docker-outside-of-docker

Checklist

  • Checked that applied changes work as expected

@gauravsaini04 gauravsaini04 requested a review from a team as a code owner January 27, 2025 02:50
@cguess
Copy link

cguess commented Mar 13, 2025

This same concern happened again today with a new release. Any chance this could be reviewed and merged?

@Mathiyarasy Mathiyarasy self-requested a review March 19, 2025 13:54
Copy link
Contributor

@Mathiyarasy Mathiyarasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the minor version

Copy link
Contributor

@Mathiyarasy Mathiyarasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If user passes the version as v2 this condition will not satisfy for latest tag and fallback mechanism will fail: Removing this condition resolves the issue

@Mathiyarasy Mathiyarasy reopened this Mar 24, 2025
@ddoyle2017 ddoyle2017 merged commit 7eec5e6 into devcontainers:main Mar 26, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants