Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md and improve guidance (plus other changes) #47

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
## Contributing Guide

For simple changes, you can easily create a fork, edit the files you want to change, open a PR, and see the result with the PR deploy preview from the Netlify bot.

> [!CAUTION]
> The documentation only supports *British* English for written language. [Spell checks](https://github.com/discord-tickets/docs/actions/workflows/spelling-check.yml) will fail if you use other languages or other forms of English. Code, code snippets, config files, etc can be in American English.

> [!TIP]
> If you are editing tables, please clone the repository locally and edit it with an appropriate IDE (like VS Code) using a markdown formatting extension.

### Local preview

If you want to preview locally, clone the repo and then run `pip install -r requirements.txt` and `mkdocs serve`.

If you choose to run a local preview, the site will not look the same as the production version, this is because it is built with a specific version of the Insiders edition of the theme, which has additional features and a different config.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it is built

This is slightly confusing, I thought "it" referred to the local preview at first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I forgot about this, will fix this


This is normal as the v4 documentation uses a newer version of MkDocs that is configured differently.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line isn't necessary with the line above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied it as it was originally and just put that on a new line, I'll fix this too

15 changes: 1 addition & 14 deletions README.md
Original file line number Diff line number Diff line change
@@ -5,22 +5,9 @@
This is the source for the Discord Tickets v4 documentation (and marketing) website.
You can view the latest build of the site [here](https://discordtickets.app/).

> **Note**
> For the v3 documentation, visit [v3.discordtickets.app](https://v3.discordtickets.app) or look at the `v3.1` branch.

## Contributing

For simple changes, you can easily create a fork, edit the files you want to change, open a PR, and see the result with the PR deploy preview from the Netlify bot.

**If you are editing tables**, please clone the repository locally, edit with an appropriate IDE (such as VS Code) and use a markdown formatting extension.

### Local preview

If you want to preview locally, clone the repo and then run `pip install -r requirements.txt` and `mkdocs serve`.

If you choose to run a local preview, the site will not look the same as the production version,
because it is built with a specific version of the Insiders edition of the theme, which has additional features and a different config.
This is normal as the v4 documentation uses a newer version of MkDocs that is configured differently.
See [CONTRIBUTING.md](./CONTRIBUTING.md)

## Spontaneous Puffin Image