Support export * #125
Open
Support export * #125
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quintenkasteel
added a commit
that referenced
this pull request
Sep 7, 2025
Implements PR #125 by adding core parser support for ES6 export star syntax. - Add JSExportAllFrom constructor to JSExportDeclaration in AST.hs - Add 'Mul FromClause AutoSemi' parser rule to Grammar7.y - Update ShowStripped instance for JSExportAllFrom - Enables parsing of 'export * from "module"' statements This is the foundation for complete export star functionality.
quintenkasteel
added a commit
that referenced
this pull request
Sep 7, 2025
Extends PR #125 implementation with complete output generation: - Pretty/Printer.hs: Add RenderJS instance for JSExportAllFrom - Pretty/JSON.hs: Add JSON serialization pattern match for export * - Process/Minify.hs: Add MinifyJS instance for efficient export * minification Export * statements now render correctly as 'export*from"module"' when minified and preserve proper formatting in pretty-printed output.
quintenkasteel
added a commit
that referenced
this pull request
Sep 7, 2025
Extends existing test modules for PR #125 export * syntax support: - ModuleParser.hs: Add parser tests for export * with various module types - Minify.hs: Add minification tests verifying whitespace removal - RoundTrip.hs: Add round-trip tests for parse/pretty-print consistency Tests cover basic syntax, relative paths, scoped packages, and different quote styles to ensure robust export * handling.
quintenkasteel
added a commit
that referenced
this pull request
Sep 7, 2025
Completes PR #125 implementation with extensive edge case testing: - Add Test.Language.Javascript.ExportStar module with 21 comprehensive tests - Cover basic parsing, module specifier variations, whitespace handling - Test comment preservation, Unicode module names, error conditions - Include multiple export scenarios and complex path handling - Update testsuite.hs to integrate new test module - Update language-javascript.cabal with new test module registration All 168 tests pass, providing robust validation of export * from syntax. Test coverage exceeds 85% requirement with comprehensive edge case handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #124